Fix compiler error on tip of tree (project-chip#32575)

tehampson · web-flow · commit 84970a085422 · 2024-03-14T13:43:21.000-07:00
* Fix compiler error on tip of tree

* Address PR comment
diff --git a/src/controller/AbstractDnssdDiscoveryController.cpp b/src/controller/AbstractDnssdDiscoveryController.cpp
@@ -34,9 +34,11 @@ void AbstractDnssdDiscoveryController::OnNodeDiscovered(const chip::Dnssd::Disco
         {
             continue;
         }
+        // TODO(#32576) Check if IP address are the same. Must account for `numIPs` in the list of `ipAddress`.
+        // Additionally, must NOT assume that the ordering is consistent.
         if (strcmp(discoveredNode.resolutionData.hostName, nodeData.resolutionData.hostName) == 0 &&
             discoveredNode.resolutionData.port == nodeData.resolutionData.port &&
-            discoveredNode.resolutionData.ipAddress == nodeData.resolutionData.ipAddress)
+            discoveredNode.resolutionData.numIPs == nodeData.resolutionData.numIPs)
         {
             discoveredNode = nodeData;
             if (mDeviceDiscoveryDelegate != nullptr)

Original file line number	Diff line number	Diff line change
`@@ -34,9 +34,11 @@ void AbstractDnssdDiscoveryController::OnNodeDiscovered(const chip::Dnssd::Disco`
`34`	`34`	`{`
`35`	`35`	`continue;`
`36`	`36`	`}`
	`37`	+ // TODO(#32576) Check if IP address are the same. Must account for `numIPs` in the list of `ipAddress`.
	`38`	`+ // Additionally, must NOT assume that the ordering is consistent.`
`37`	`39`	`if (strcmp(discoveredNode.resolutionData.hostName, nodeData.resolutionData.hostName) == 0 &&`
`38`	`40`	`discoveredNode.resolutionData.port == nodeData.resolutionData.port &&`
`39`		`- discoveredNode.resolutionData.ipAddress == nodeData.resolutionData.ipAddress)`
	`41`	`+ discoveredNode.resolutionData.numIPs == nodeData.resolutionData.numIPs)`
`40`	`42`	`{`
`41`	`43`	`discoveredNode = nodeData;`
`42`	`44`	`if (mDeviceDiscoveryDelegate != nullptr)`