Remove TODO in AudioOutputManager

And fix potential memory violation due to memcpy

Author: erwinpan1

examples/chef/common/clusters/audio-output/AudioOutputManager.cpp

@@ -46,7 +46,6 @@ uint8_t AudioOutputManager::HandleGetCurrentOutput()
 
 CHIP_ERROR AudioOutputManager::HandleGetOutputList(AttributeValueEncoder & aEncoder)
 {
-    // TODO: Insert code here
     return aEncoder.EncodeList([this](const auto & encoder) -> CHIP_ERROR {
         for (auto const & outputInfo : this->mOutputs)
         {
@@ -58,16 +57,16 @@ CHIP_ERROR AudioOutputManager::HandleGetOutputList(AttributeValueEncoder & aEnco
 
 bool AudioOutputManager::HandleRenameOutput(const uint8_t & index, const chip::CharSpan & name)
 {
-    // TODO: Insert code here
     bool audioOutputRenamed = false;
 
     for (OutputInfoType & output : mOutputs)
     {
         if (output.index == index)
         {
             audioOutputRenamed = true;
-            memcpy(this->Data(index), name.data(), name.size());
-            output.name = chip::CharSpan(this->Data(index), name.size());
+	    const size_t len = std::min(mBufMax, name.size());
+            memcpy(this->Data(index), name.data(), len);
+            output.name = chip::CharSpan(this->Data(index), len);
         }
     }
 
@@ -76,7 +75,6 @@ bool AudioOutputManager::HandleRenameOutput(const uint8_t & index, const chip::C
 
 bool AudioOutputManager::HandleSelectOutput(const uint8_t & index)
 {
-    // TODO: Insert code here
     bool audioOutputSelected = false;
     for (OutputInfoType & output : mOutputs)
     {

examples/chef/common/clusters/audio-output/AudioOutputManager.h

@@ -40,5 +40,6 @@ class AudioOutputManager : public AudioOutputDelegate
     uint8_t mCurrentOutput;
     std::vector<OutputInfoType> mOutputs;
     // Magic numbers are here on purpose, please allocate memory
-    char mCharDataBuffer[10][32];
+    static constexpr size_t mBufMax = 32;
+    char mCharDataBuffer[10][mBufMax];
 };