-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide PyInstaller binaries (IDFGH-14261) #20
Comments
Hi, thank you for the feature request, but we have decided that we won't do this now. The implementation of this itself would be easy, but adding such binaries would require a lot of maintenance from our side (signing binaries, tests, etc.). There are a lot of issues that we need to constantly fix in esptool because of this. On top of that, binaries from PyInstaller often get marked by some antivirus programs as false positives. Python applications are primarily supposed to be interpreted, and using PyInstaller is causing multiple drawbacks. We may reconsider this in the future if more requests from users come. I hope you understand. |
Totally understand, I know PyInstaller is not the best. If nebkat@202fff0 could be considered so I can maintain local builds for internal use without any modifications that would be great, but no problem if not.
A side note - as a long time ESP-IDF developer I have noticed that there are a quite a lot of tools and options in the ecosystem that do not seem to be very well known - After some thought I think the best way to improve this would be to split up the API Guides section of the documentation into separate "Development Guides" and "API Guides". Topics such as Build System, C++ Support, Tools and Unit Testing are easily lost amongst the peripheral API links. I can create an issue on esp-idf if you'd be interested in some more ideas - we spend a lot of time on DevOps and would love to have a central resource to share this information with others. |
I don't see a reason why not. Feel free to create a PR, and we will include it.
We always welcome any ideas for improvements, so if you have any suggestions, we would be happy to hear about them. Thank you! |
Checklist
Feature description
Inspired by the releases provided by esptool, consider generating PyInstaller binaries for
esp_idf_monitor
.Use cases
Setting
esp-idf-monitor
up on non-technical colleagues computers involves installing Python, explaining the use ofpython -m esp_idf_monitor
and is generally somewhat of a chore.This could be reduced to download, unzip and run 😃
Alternatives
No response
Additional context
This can be achieved by:
Required due to pyinstaller/pyinstaller#2560.
Followed by:
The text was updated successfully, but these errors were encountered: