Skip to content

Commit f103a69

Browse files
committed
Merge branch 'fix/light_example_boot_buttons' into 'main'
fix: Fixed boot GPIO number on ESP32C6, ESP32H2 and ESP32C3. Closes IDF-9172 See merge request app-frameworks/esp-matter!640
2 parents 5bf8ecb + bed4aa9 commit f103a69

5 files changed

+48
-16
lines changed

examples/light/main/app_driver.cpp

+16-14
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ extern uint16_t light_endpoint_id;
2424
/* Do any conversions/remapping for the actual value here */
2525
static esp_err_t app_driver_light_set_power(led_indicator_handle_t handle, esp_matter_attr_val_t *val)
2626
{
27-
#if BSP_LED_NUM > 0
27+
#if CONFIG_BSP_LEDS_NUM > 0
2828
esp_err_t err = ESP_OK;
2929
if (val->val.b) {
3030
err = led_indicator_start(handle, BSP_LED_ON);
@@ -41,7 +41,7 @@ static esp_err_t app_driver_light_set_power(led_indicator_handle_t handle, esp_m
4141
static esp_err_t app_driver_light_set_brightness(led_indicator_handle_t handle, esp_matter_attr_val_t *val)
4242
{
4343
int value = REMAP_TO_RANGE(val->val.u8, MATTER_BRIGHTNESS, STANDARD_BRIGHTNESS);
44-
#if BSP_LED_NUM > 0
44+
#if CONFIG_BSP_LEDS_NUM > 0
4545
return led_indicator_set_brightness(handle, value);
4646
#else
4747
ESP_LOGI(TAG, "LED set brightness: %d", value);
@@ -52,10 +52,11 @@ static esp_err_t app_driver_light_set_brightness(led_indicator_handle_t handle,
5252
static esp_err_t app_driver_light_set_hue(led_indicator_handle_t handle, esp_matter_attr_val_t *val)
5353
{
5454
int value = REMAP_TO_RANGE(val->val.u8, MATTER_HUE, STANDARD_HUE);
55-
#if BSP_LED_NUM > 0
56-
uint32_t hsv = led_indicator_get_hsv(handle);
57-
SET_HUE(hsv, value);
58-
return led_indicator_set_hsv(handle, hsv);
55+
#if CONFIG_BSP_LEDS_NUM > 0
56+
led_indicator_ihsv_t hsv;
57+
hsv.value = led_indicator_get_hsv(handle);
58+
hsv.h = value;
59+
return led_indicator_set_hsv(handle, hsv.value);
5960
#else
6061
ESP_LOGI(TAG, "LED set hue: %d", value);
6162
return ESP_OK;
@@ -65,10 +66,11 @@ static esp_err_t app_driver_light_set_hue(led_indicator_handle_t handle, esp_mat
6566
static esp_err_t app_driver_light_set_saturation(led_indicator_handle_t handle, esp_matter_attr_val_t *val)
6667
{
6768
int value = REMAP_TO_RANGE(val->val.u8, MATTER_SATURATION, STANDARD_SATURATION);
68-
#if BSP_LED_NUM > 0
69-
uint32_t hsv = led_indicator_get_hsv(handle);
70-
SET_SATURATION(hsv, value);
71-
return led_indicator_set_hsv(handle, hsv);
69+
#if CONFIG_BSP_LEDS_NUM > 0
70+
led_indicator_ihsv_t hsv;
71+
hsv.value = led_indicator_get_hsv(handle);
72+
hsv.s = value;
73+
return led_indicator_set_hsv(handle, hsv.value);
7274
#else
7375
ESP_LOGI(TAG, "LED set saturation: %d", value);
7476
return ESP_OK;
@@ -78,7 +80,7 @@ static esp_err_t app_driver_light_set_saturation(led_indicator_handle_t handle,
7880
static esp_err_t app_driver_light_set_temperature(led_indicator_handle_t handle, esp_matter_attr_val_t *val)
7981
{
8082
uint32_t value = REMAP_TO_RANGE_INVERSE(val->val.u16, STANDARD_TEMPERATURE_FACTOR);
81-
#if BSP_LED_NUM > 0
83+
#if CONFIG_BSP_LEDS_NUM > 0
8284
return led_indicator_set_color_temperature(handle, value);
8385
#else
8486
ESP_LOGI(TAG, "LED set temperature: %ld", value);
@@ -181,10 +183,10 @@ esp_err_t app_driver_light_set_defaults(uint16_t endpoint_id)
181183

182184
app_driver_handle_t app_driver_light_init()
183185
{
184-
#if BSP_LED_NUM > 0
186+
#if CONFIG_BSP_LEDS_NUM > 0
185187
/* Initialize led */
186-
led_indicator_handle_t leds[BSP_LED_NUM];
187-
ESP_ERROR_CHECK(bsp_led_indicator_create(leds, NULL, BSP_LED_NUM));
188+
led_indicator_handle_t leds[CONFIG_BSP_LEDS_NUM];
189+
ESP_ERROR_CHECK(bsp_led_indicator_create(leds, NULL, CONFIG_BSP_LEDS_NUM));
188190
led_indicator_set_hsv(leds[0], SET_HSV(DEFAULT_HUE, DEFAULT_SATURATION, DEFAULT_BRIGHTNESS));
189191

190192
return (app_driver_handle_t)leds[0];
+21
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
CONFIG_IDF_TARGET="esp32c3"
2+
3+
# Enable OTA Requestor
4+
CONFIG_ENABLE_OTA_REQUESTOR=y
5+
6+
# Disable AP
7+
CONFIG_ENABLE_WIFI_STATION=y
8+
CONFIG_ENABLE_WIFI_AP=n
9+
10+
# ESP32-C3-DevKitC-02 Settings
11+
# Buttons
12+
CONFIG_BSP_BUTTONS_NUM=1
13+
CONFIG_BSP_BUTTON_1_TYPE_GPIO=y
14+
CONFIG_BSP_BUTTON_1_GPIO=9
15+
CONFIG_BSP_BUTTON_1_LEVEL=0
16+
# LEDs
17+
CONFIG_BSP_LEDS_NUM=1
18+
CONFIG_BSP_LED_TYPE_RGB=y
19+
CONFIG_BSP_LED_RGB_GPIO=8
20+
CONFIG_BSP_LED_RGB_BACKEND_RMT=y
21+

examples/light/sdkconfig.defaults.esp32c6

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ CONFIG_ENABLE_CHIP_SHELL=y
4242
# Buttons
4343
CONFIG_BSP_BUTTONS_NUM=1
4444
CONFIG_BSP_BUTTON_1_TYPE_GPIO=y
45-
CONFIG_BSP_BUTTON_1_GPIO=0
45+
CONFIG_BSP_BUTTON_1_GPIO=9
4646
CONFIG_BSP_BUTTON_1_LEVEL=0
4747
# LEDs
4848
CONFIG_BSP_LEDS_NUM=1

examples/light/sdkconfig.defaults.esp32h2

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ CONFIG_ESP_SECURE_CERT_DS_PERIPHERAL=y
5858
# Buttons
5959
CONFIG_BSP_BUTTONS_NUM=1
6060
CONFIG_BSP_BUTTON_1_TYPE_GPIO=y
61-
CONFIG_BSP_BUTTON_1_GPIO=0
61+
CONFIG_BSP_BUTTON_1_GPIO=9
6262
CONFIG_BSP_BUTTON_1_LEVEL=0
6363
# LEDs
6464
CONFIG_BSP_LEDS_NUM=1

examples/light/sdkconfig.defaults.ext_plat_ci

+9
Original file line numberDiff line numberDiff line change
@@ -50,3 +50,12 @@ CONFIG_ESP_MATTER_NVS_USE_COMPACT_ATTR_STORAGE=y
5050

5151
# Enable HKDF in mbedtls
5252
CONFIG_MBEDTLS_HKDF_C=y
53+
54+
# ESP32-DevKit Settings
55+
# Buttons
56+
CONFIG_BSP_BUTTONS_NUM=1
57+
CONFIG_BSP_BUTTON_1_TYPE_GPIO=y
58+
CONFIG_BSP_BUTTON_1_GPIO=0
59+
CONFIG_BSP_BUTTON_1_LEVEL=0
60+
# LEDs
61+
CONFIG_BSP_LEDS_NUM=0

0 commit comments

Comments
 (0)