Multi plug improvements (CON-1465) #1202
Conversation
|
|
hankedan000
force-pushed
the
multi-plug-improvements
branch
from
b1859f4 to
dae802f
Compare
github-actions
bot
changed the title
Glad to hear that this example was helpful in curating your solution. |
|
@hankedan000 Added minor comments, change LGTM! Also, please resolve the addressed comments. |
|
LGTM! |
* adds reset button logic * adds support for upt to 16 plugs Add ability to configure up to 16 plugs Add factory reset via GPIO Use bsp instead of device_hal for button initialization Check if reset button IO pin # conflicts with plugs Update default IO to be usable accross all supported targets Updates readme Adds reset_gpio out arg. Fixed error code usage. Fixed non-static variable names
hankedan000
force-pushed
the
multi-plug-improvements
branch
from
575d4fc to
a41e41b
Compare
|
Is there a way to add button support for toggling the lights ? Something like GPIO_BUTTON_1 would toggle GPIO_PLUG_1 on press down. |
Yes, that could be implemented, but it doesn't support that feature currently. I didn't really need that feature for what I was updating this for, and I don't think it was implemented originally due to the simplistic nature of these example projects. If you're looking for an example on how to implement such a feature, I'd recommend looking here: https://github.com/espressif/esp-matter/tree/main/examples/light/main |
|
@hankedan000 We have merged this PR, Thank you for contributing! |
I wanted to make a multi-zone light controlled, and this multi-on-off-plugin example was really close to what I wanted. I just wanted to control more lights really. This updates makes this example project more of an "out of the box" solution for my project, and I hope others will find the same.
default options
full options