Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong include paths when using the external platform feature (CON-1607) #1336

Open
sbh82 opened this issue Mar 20, 2025 · 0 comments
Open

Wrong include paths when using the external platform feature (CON-1607) #1336

sbh82 opened this issue Mar 20, 2025 · 0 comments

Comments

@sbh82
Copy link

sbh82 commented Mar 20, 2025

When using the external platform feature, there are some wrong include directives that lookup to the default ESP32 platform and not to the custom external platform defined.
The wrong includes are in the following files:

components/esp_matter/esp_matter_core.cpp
components/esp_matter/esp_matter_ota.cpp
components/esp_matter/esp_matter_ota.h
components/esp_matter/esp_matter_providers.cpp
components/esp_matter_console/esp_matter_console.cpp
components/esp_matter_console/esp_matter_console_otcli.cpp
components/esp_matter_controller/core/esp_matter_controller_client.cpp

In all these files there is the static path #include <platform/ESP32/xxxxxx> but it's not correct when using the external platform.

In components/esp_matter/esp_matter_ota.h for example the include is:

#include <platform/ESP32/OTAImageProcessorImpl.h>

but the path platform/ESP32 should not be static but dynamic because I'm using the external platform where the platform path is different (platform/ESP32_custom in my case).
In this way it does not compile my custom code implementation but the default implementation defined in platform/ESP32.

@github-actions github-actions bot changed the title Wrong include paths when using the external platform feature Wrong include paths when using the external platform feature (CON-1607) Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant