Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #include "soc/usb_pins.h" from esp_tinyusb (IEC-270) #138

Closed
2 tasks done
tore-espressif opened this issue Feb 21, 2025 · 0 comments
Closed
2 tasks done

Remove #include "soc/usb_pins.h" from esp_tinyusb (IEC-270) #138

tore-espressif opened this issue Feb 21, 2025 · 0 comments
Assignees
@tore-espressif
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Milestone
esp_tinyusb v2.0.0

Comments

@tore-espressif
Copy link
Collaborator

tore-espressif commented Feb 21, 2025 •
edited
Loading

Answers checklist.

  • I have read the documentation of the component in question and the issue is not addressed there.
  • I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report

soc/usb_pins.h will be removed in IDF v6.0, we should stop using it esp_tinyusb

This will affect our External PHY configuration. The are 2 viable options:

  • User must pass Ext. PHY configuration to tinyusb_install where the PHY will be initialized
  • Selected solution: The user must init the PHY himself (similar to skip_phy_setup in USB Host)
@tore-espressif tore-espressif added this to the esp_tinyusb v2.0.0 milestone Feb 21, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Feb 21, 2025
@github-actions github-actions bot changed the title Remove #include "soc/usb_pins.h" from esp_tinyusb Remove #include "soc/usb_pins.h" from esp_tinyusb (IEC-270) Feb 21, 2025
tore-espressif added a commit that referenced this issue Feb 27, 2025
@tore-espressif
refactor(esp_tinyusb): Add an option to skip PHY setup
a4acb70 
esp_tinyusb will no longer initialize external PHY. If external PHY is required,
it must be explicitly initialized by user and esp_tinyusb
must be configured with `skip_phy_setup = true`

Closes #138
@tore-espressif tore-espressif mentioned this issue Feb 27, 2025
Merged
tore-espressif added a commit that referenced this issue Mar 3, 2025
@tore-espressif
refactor(esp_tinyusb): Add an option to skip PHY setup
4acfec9 
esp_tinyusb will no longer initialize external PHY. If external PHY is required,
it must be explicitly initialized by user and esp_tinyusb
must be configured with `skip_phy_setup = true`

Closes #138
tore-espressif added a commit that referenced this issue Mar 20, 2025
@tore-espressif
refactor(esp_tinyusb): Add an option to skip PHY setup
af18738 
esp_tinyusb will no longer initialize external PHY. If external PHY is required,
it must be explicitly initialized by user and esp_tinyusb
must be configured with `skip_phy_setup = true`

Closes #138
@tore-espressif tore-espressif self-assigned this Mar 20, 2025
@espressif-bot espressif-bot added Status: In Progress Issue is being worked on Status: Reviewing Issue is being reviewed and removed Status: Opened Issue is new Status: In Progress Issue is being worked on labels Mar 20, 2025
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Reviewing Issue is being reviewed labels Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tore-espressif tore-espressif

Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Milestone
esp_tinyusb v2.0.0
Development

No branches or pull requests
2 participants
@espressif-bot @tore-espressif