API Entreprise start: show disclaimer if no valid editor

Author: skelz0r

app/javascript/controllers/choose_authorization_request_form_controller.js

@@ -1,7 +1,7 @@
 import { Controller } from '@hotwired/stimulus'
 
 export default class extends Controller {
-  static targets = ['editors', 'editor', 'forms', 'form', 'noTeamDisclaimer']
+  static targets = ['editors', 'editor', 'forms', 'form', 'noTeamDisclaimer', 'noEditorDisclaimer']
   static values = {
     editors: Array,
     targetUseCase: String
@@ -35,7 +35,7 @@ export default class extends Controller {
     this.formTargets.forEach((form) => {
       const formTags = this._getFormTags(form)
 
-      if (formTags.includes(editor) || formTags.includes('default')) {
+      if (formTags.includes(editor)) {
         form.classList.remove('fr-hidden')
       } else {
         form.classList.add('fr-hidden')
@@ -46,7 +46,11 @@ export default class extends Controller {
       this._hideOtherUseCaseForms()
     }
 
-    this._showFormsBlock()
+    if (this._noForm()) {
+      this._showNoEditorDisclaimer()
+    } else {
+      this._showFormsBlock()
+    }
   }
 
   _getFormTags (form) {
@@ -94,12 +98,24 @@ export default class extends Controller {
     })
     this.formsTarget.classList.add('fr-hidden')
     this.noTeamDisclaimerTarget.classList.add('fr-hidden')
+    this.noEditorDisclaimerTarget.classList.add('fr-hidden')
   }
 
   _showNoTeamDisclaimer () {
     this.noTeamDisclaimerTarget.classList.remove('fr-hidden')
   }
 
+  _showNoEditorDisclaimer () {
+    this.noEditorDisclaimerTarget.classList.remove('fr-hidden')
+    this.formsTarget.classList.add('fr-hidden')
+  }
+
+  _noForm () {
+    return this.formTargets.every((form) => {
+      return form.classList.contains('fr-hidden')
+    })
+  }
+
   _hideOtherUseCaseForms () {
     this.formTargets.forEach((form) => {
       const formTags = this._getFormTags(form)

app/views/authorization_request_forms/index/_api_entreprise.html.erb

@@ -56,7 +56,7 @@
     </div>
   </fieldset>
 
-  <div data-choose-authorization-request-form-target="editors" id="editor-list" class="fr-hidden">
+  <div data-choose-authorization-request-form-target="editors" id="editors-list" class="fr-hidden">
     <h3>
       Quel est votre éditeur de logiciel ?
     </h3>
@@ -110,6 +110,20 @@
       <br />
 
       🔎 L’API Entreprise s’utilise au travers d’un logiciel métier, comme par exemple un profil acheteur pour les marchés publics. Si vous collectez et traitez les données à la main, vous n’avez probablement pas un logiciel dédié aux démarches.
+
+      <br />
+
+      Vous pouvez utiliser l'espace agent sur l'annuaires des entreprises.
+    </p>
+  </div>
+
+  <div data-choose-authorization-request-form-target="noEditorDisclaimer" id="no-editor-disclaimer" class="fr-bg-alt-blue-france fr-hidden">
+    <p class="center fr-px-5w fr-py-1w">
+    Vous êtes éligible mais votre éditeur ne semble pas utiliser l'API Entreprise, ou son intégration ne nécessite aucune action de votre part.
+
+    <br />
+
+    Si votre éditeur n'intégre pas API Entreprise, vous pouvez utiliser l'espace agent sur l'annuaires des entreprises.
     </p>
   </div>
 </div>

spec/features/authorization_requests/api_entreprise_spec.rb

@@ -5,43 +5,75 @@
     sign_in(user)
   end
 
-  describe 'when we do not have a use_case in the url' do
-    before do
-      visit choose_authorization_request_form_path(authorization_definition_id: 'api_entreprise')
+  describe 'use case filtering' do
+    describe 'when we do not have a use_case in the url' do
+      before do
+        visit choose_authorization_request_form_path(authorization_definition_id: 'api_entreprise')
+      end
+
+      context 'when we choose internal team' do
+        before do
+          find('label', text: 'Vos développeurs').click
+        end
+
+        it 'shows more forms with the default one' do
+          expect(all('.authorization-request-form-card').count).to be > 2
+
+          expect(page).to have_css('#authorization_request_form_api-entreprise')
+          expect(page).to have_css('#authorization_request_form_api-entreprise-marches-publics')
+          expect(page).to have_css('#authorization_request_form_api-entreprise-aides-publiques')
+        end
+      end
     end
 
-    context 'when we choose internal team' do
+    describe 'when we have a use_case in the url' do
+      let(:use_case) { 'marches_publics' }
+
       before do
-        find('label', text: 'Vos développeurs').click
+        visit choose_authorization_request_form_path(authorization_definition_id: 'api_entreprise', use_case:)
       end
 
-      it 'shows more forms with the default one' do
-        expect(all('.authorization-request-form-card').count).to be > 2
+      context 'when we choose internal team' do
+        before do
+          find('label', text: 'Vos développeurs').click
+        end
+
+        it 'shows only this form with the default one' do
+          expect(page).to have_css('.authorization-request-form-card', count: 2)
 
-        expect(page).to have_css('#authorization_request_form_api-entreprise')
-        expect(page).to have_css('#authorization_request_form_api-entreprise-marches-publics')
-        expect(page).to have_css('#authorization_request_form_api-entreprise-aides-publiques')
+          expect(page).to have_css('#authorization_request_form_api-entreprise')
+          expect(page).to have_css('#authorization_request_form_api-entreprise-marches-publics')
+        end
       end
     end
   end
 
-  describe 'when we have a use_case in the url' do
-    let(:use_case) { 'marches_publics' }
-
+  describe 'no available editor' do
     before do
-      visit choose_authorization_request_form_path(authorization_definition_id: 'api_entreprise', use_case:)
+      visit choose_authorization_request_form_path(authorization_definition_id: 'api_entreprise')
+
+      find('label', text: 'Votre éditeur').click
+
+      within('#editors-list') do
+        find('label', text: editor).click
+      end
     end
 
-    context 'when we choose internal team' do
-      before do
-        find('label', text: 'Vos développeurs').click
+    context 'when editor has forms' do
+      let(:editor) { 'MGDIS' }
+
+      it 'shows editors forms' do
+        expect(page).to have_css('.authorization-request-form-card', count: 1)
+
+        expect(page).to have_css('#authorization_request_form_api-entreprise-mgdis')
       end
+    end
 
-      it 'shows only this form with the default one' do
-        expect(page).to have_css('.authorization-request-form-card', count: 2)
+    context 'when editor has no forms (choose none)' do
+      let(:editor) { 'Aucun' }
 
-        expect(page).to have_css('#authorization_request_form_api-entreprise')
-        expect(page).to have_css('#authorization_request_form_api-entreprise-marches-publics')
+      it 'shows no forms' do
+        expect(page).to have_css('#no-editor-disclaimer')
       end
     end
   end