Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-7851: multiple fixes and refinements #9234

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Update EIP-7851: multiple fixes and refinements #9234

merged 1 commit into from
Jan 12, 2025
+31 −39

Conversation

colinlyguo
Copy link
Contributor

This PR:

  • makes the magician link consistent with the EIP title.
  • fixes some fact errors, such as it mentions that the alternative smart contract approach "leaks" the design of a (widely used) programming language into the Ethereum core protocol. I later found it was wrong since the contract does not need to be written in any specific programming language.
  • removes some unnecessary statements. e.g. Forwards compatibility for removing EOAs session. because (i) it's just a possible path to go. (ii) the statement is not very related to "forwards compatibility".
  • statement and code refinements.

@colinlyguo colinlyguo requested a review from eth-bot as a code owner January 12, 2025 22:04
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Jan 12, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Jan 12, 2025 •
edited
Loading

✅ All reviewers have approved.

@eth-bot eth-bot changed the title EIP-7851: multiple fixes and refinements Update EIP-7851: multiple fixes and refinements Jan 12, 2025
@eth-bot eth-bot enabled auto-merge (squash) January 12, 2025 22:05
eth-bot
eth-bot approved these changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 05fadf7 into ethereum:master Jan 12, 2025
15 of 16 checks passed
@colinlyguo colinlyguo deleted the several-fixes branch January 12, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eth-bot eth-bot eth-bot approved these changes

Assignees
No one assigned
Labels
c-update Modifies an existing proposal s-draft This EIP is a Draft t-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colinlyguo @eth-bot