Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-7691: clarify that all 3 EL constants change in Prague #9243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Jan 15, 2025

Otherwise the doc would say:

"The execution clients would continue to use MAX_BLOB_GAS_PER_BLOCK (...) for the cancun fork"

while MAX_BLOB_GAS_PER_BLOCK is given a new value, which threw me off for a second.

@pdobacz pdobacz requested a review from eth-bot as a code owner January 15, 2025 12:53
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Jan 15, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Jan 15, 2025

File EIPS/eip-7691.md

Requires 1 more reviewers from @adietrichs, @nerolation, @parithosh, @samcm, @Savid

@eth-bot eth-bot added the a-review Waiting on author to review label Jan 15, 2025
Copy link

The commit 28cb3af (as a parent of 42de71c) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jan 15, 2025
Copy link
Contributor

@nerolation nerolation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, waiting for 1 more review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-review This EIP is in Review t-core w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants