You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, far we have been maintaining our own expression simplification passes and we continuously need to add more simplification rules. Currently, we have a simplify primitive which is around 700 lines of code and another simplification pass at codegen which is around 100 lines. It might make sense to experiment with using a library for expression simplification instead of writing these on our own. I have tried simplifying some of the important cases we care about in sympy and it does a good job at them (and it can handle other cases that we haven't handled yet).
I think it is worth it to invest a few hours in trying to rewrite all of our simplification using sympy (or some other library) and see if we can pass all of our existing tests.
The text was updated successfully, but these errors were encountered:
So, far we have been maintaining our own expression simplification passes and we continuously need to add more simplification rules. Currently, we have a
simplify
primitive which is around 700 lines of code and another simplification pass at codegen which is around 100 lines. It might make sense to experiment with using a library for expression simplification instead of writing these on our own. I have tried simplifying some of the important cases we care about in sympy and it does a good job at them (and it can handle other cases that we haven't handled yet).I think it is worth it to invest a few hours in trying to rewrite all of our simplification using sympy (or some other library) and see if we can pass all of our existing tests.
The text was updated successfully, but these errors were encountered: