Support interpolation modifiers for WGSL (shader-slang#5641)

* wgsl: Support interpolation modifiers

* Move struct key decorations to flattened structs.
** This includes interpolation mode decorations, which must be in the flattened struct.
* Emit interpolation attribute.
* Enable tests/render/nointerpolation.hlsl for WGSL, as a result.

This closes shader-slang#5625.

* Add new expected output for 'nointerpolation' test

Author: aleino-nv

source/slang/slang-emit-wgsl.cpp

@@ -1506,4 +1506,53 @@ void WGSLSourceEmitter::emitIntrinsicCallExprImpl(
         inOuterPrec);
 }
 
+void WGSLSourceEmitter::emitInterpolationModifiersImpl(
+    IRInst* varInst,
+    IRType* /* valueType */,
+    IRVarLayout* /* layout */)
+{
+    char const* interpolationType = nullptr;
+    char const* interpolationSampling = nullptr;
+    for (auto dd : varInst->getDecorations())
+    {
+        if (dd->getOp() != kIROp_InterpolationModeDecoration)
+            continue;
+        auto decoration = (IRInterpolationModeDecoration*)dd;
+        IRInterpolationMode mode = decoration->getMode();
+        switch (mode)
+        {
+        case IRInterpolationMode::NoInterpolation:
+            interpolationType = "flat";
+            break;
+        case IRInterpolationMode::NoPerspective:
+        case IRInterpolationMode::Linear:
+            interpolationType = "linear";
+            break;
+        case IRInterpolationMode::Sample:
+            interpolationSampling = "sample";
+            break;
+        case IRInterpolationMode::Centroid:
+            interpolationSampling = "centroid";
+            break;
+        }
+    }
+
+    if (interpolationType)
+    {
+        m_writer->emit("@interpolate(");
+        m_writer->emit(interpolationType);
+        if (interpolationSampling)
+        {
+            m_writer->emit(", ");
+            m_writer->emit(interpolationSampling);
+        }
+        m_writer->emit(") ");
+    }
+
+    // TODO: Check the following:
+    // "User-defined vertex outputs and fragment inputs of scalar or vector
+    //  integer type must always be specified with interpolation type flat."
+    // https://www.w3.org/TR/WGSL/#interpolation
+}
+
 } // namespace Slang

source/slang/slang-emit-wgsl.h

@@ -42,6 +42,10 @@ class WGSLSourceEmitter : public CLikeSourceEmitter
     virtual void emitStructFieldAttributes(IRStructType* structType, IRStructField* field)
         SLANG_OVERRIDE;
     virtual void emitCallArg(IRInst* inst) SLANG_OVERRIDE;
+    virtual void emitInterpolationModifiersImpl(
+        IRInst* varInst,
+        IRType* valueType,
+        IRVarLayout* layout) SLANG_OVERRIDE;
 
     virtual void emitIntrinsicCallExprImpl(
         IRCall* inst,

source/slang/slang-ir-wgsl-legalize.cpp

@@ -629,7 +629,10 @@ struct LegalizeWGSLEntryPointContext
         // 2. If IRStructType:
         //  2a. Recurse this function with 'decorations that carry semantic info' from parent.
         // 3. If not IRStructType:
-        //  3a. Emit 'newField' equal to 'oldField', add 'decorations which carry semantic info'.
+        //  3a. Emit 'newField' with 'newKey' equal to 'oldField' and 'oldKey', respectively,
+        //      where 'oldKey' is the key corresponding to 'oldField'.
+        //      Add 'decorations which carry semantic info' to 'newField', and move all decorations
+        //      of 'oldKey' to 'newKey'.
         //  3b. Store a mapping from 'oldField' to 'newField' in 'mapFieldToField'. This info is
         //  needed to copy between types.
         for (auto oldField : src->getFields())
@@ -674,7 +677,7 @@ struct LegalizeWGSLEntryPointContext
 
             // step 3a
             auto newKey = builder.createStructKey();
-            copyNameHintAndDebugDecorations(newKey, oldKey);
+            oldKey->transferDecorationsTo(newKey);
 
             auto newField = builder.createStructField(dst, newKey, oldField->getFieldType());
             copyNameHintAndDebugDecorations(newField, oldField);

tests/expected-failure-github.txt

@@ -20,4 +20,3 @@ tests/language-feature/generics/variadic-0.slang.4 syn (wgpu)
 tests/language-feature/shader-params/interface-shader-param-ordinary.slang.4 syn (wgpu)
 tests/language-feature/swizzles/matrix-swizzle-write-array.slang.3 syn (wgpu)
 tests/language-feature/swizzles/matrix-swizzle-write-swizzle.slang.3 syn (wgpu)
-tests/render/nointerpolation.hlsl (wgpu)

tests/render/nointerpolation.hlsl

@@ -1,6 +1,4 @@
 //TEST(smoke):COMPARE_HLSL_RENDER:
-// WGSL: nointerpolate doesn't work #5625
-//DISABLE_TEST(smoke):COMPARE_HLSL_RENDER: -wgpu
 // TODO: Investigate Metal failure
 //DISABLE_TEST(smoke):COMPARE_HLSL_RENDER: -mtl
 

tests/render/nointerpolation.hlsl.3.expected

@@ -0,0 +1,5 @@
+result code = 0
+standard error = {
+}
+standard output = {
+}