Django UpdateView / ClassVar usage

[last-partizan]

Tecnically, this is question about django, but it looks like i can reproduce it without Django.

from typing import ClassVar

class Model: ...

class UpdateViewV1:
    model: type[Model]

class UpdateViewV2:
    model: ClassVar[type[Model]]

class Book(Model): ...

class UpdateBookViewV1(UpdateViewV1):
# ERROR Class member `UpdateBookViewV1.model` overrides parent class `UpdateViewV1` in an inconsistent manner [bad-override]
    model = Book

class UpdateBookViewV2(UpdateViewV2):
    model = Book

---

Are we supposed to mark every member that can be overriden in subclasses as ClassVar?

Both mypy and pyright treat a case without ClassVar as normal case and do not raise error here.

[rchen152]

Thanks for finding this! I believe this is a bug in Pyrefly rather than an intentional decision.

[rchen152]

I opened #839

[rchen152]

This was fixed in 828499b. The fix just missed the cut-off for 0.28.0, but it'll be in the next release.