Skip to content

Commit 26d33b8

Browse files
committed
update tests
1 parent c485371 commit 26d33b8

File tree

4 files changed

+3
-15
lines changed

4 files changed

+3
-15
lines changed

faunadb-java/src/main/java/com/faunadb/client/types/MetricsResponse.java

+1-3
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,10 @@ public enum Metrics {
5151
QUERY_BYTES_IN("x-query-bytes-in"),
5252
QUERY_BYTES_OUT("x-query-bytes-out"),
5353
QUERY_TIME("x-query-time"),
54-
READ_OPS("x-read-ops"),
5554
STORAGE_BYTES_READ("x-storage-bytes-read"),
5655
STORAGE_BYTES_WRITE("x-storage-bytes-write"),
5756
TXN_RETRIES("x-txn-retries"),
58-
TXN_TIME("x-txn-time"),
59-
WRITE_OPS("x-write-ops");
57+
TXN_TIME("x-txn-time");
6058

6159
private final String metric;
6260

faunadb-java/src/test/java/com/faunadb/client/ClientSpec.java

+1-5
Original file line numberDiff line numberDiff line change
@@ -325,12 +325,10 @@ public void shouldReturnMetricsData() throws Exception {
325325
Optional<String> queryBytesIn = metricsResponse.getMetric(MetricsResponse.Metrics.QUERY_BYTES_IN);
326326
Optional<String> queryBytesOut = metricsResponse.getMetric(MetricsResponse.Metrics.QUERY_BYTES_OUT);
327327
Optional<String> queryTime = metricsResponse.getMetric(MetricsResponse.Metrics.QUERY_TIME);
328-
Optional<String> readOps = metricsResponse.getMetric(MetricsResponse.Metrics.READ_OPS);
329328
Optional<String> storageBytesRead = metricsResponse.getMetric(MetricsResponse.Metrics.STORAGE_BYTES_READ);
330329
Optional<String> storageBytesWrite = metricsResponse.getMetric(MetricsResponse.Metrics.STORAGE_BYTES_WRITE);
331330
Optional<String> txnRetries = metricsResponse.getMetric(MetricsResponse.Metrics.TXN_RETRIES);
332331
Optional<String> txnTime = metricsResponse.getMetric(MetricsResponse.Metrics.TXN_TIME);
333-
Optional<String> writeOps = metricsResponse.getMetric(MetricsResponse.Metrics.WRITE_OPS);
334332

335333
assertThat(byteReadOps.isPresent(), is(true));
336334
assertThat(byteWriteOps.isPresent(), is(true));
@@ -339,12 +337,10 @@ public void shouldReturnMetricsData() throws Exception {
339337
assertThat(queryBytesIn.isPresent(), is(true));
340338
assertThat(queryBytesOut.isPresent(), is(true));
341339
assertThat(queryTime.isPresent(), is(true));
342-
assertThat(readOps.isPresent(), is(true));
343340
assertThat(storageBytesRead.isPresent(), is(true));
344341
assertThat(storageBytesWrite.isPresent(), is(true));
345342
assertThat(txnRetries.isPresent(), is(true));
346343
assertThat(txnTime.isPresent(), is(true));
347-
assertThat(writeOps.isPresent(), is(true));
348344
}
349345

350346
@Test
@@ -3171,7 +3167,7 @@ public void streamFailsIfTargetDoesNotExist() throws Exception {
31713167
@Test
31723168
public void streamFailsIfQueryIsNotReadOnly() throws Exception {
31733169
thrown.expectCause(isA(BadRequestException.class));
3174-
thrown.expectMessage(containsString("invalid expression: Write effect in read-only query expression."));
3170+
thrown.expectMessage(containsString("invalid expression: Call performs a write, which is not allowed in stream requests."));
31753171

31763172
adminClient.stream(CreateCollection(Collection("spells"))).get();
31773173
}

faunadb-scala/src/main/scala/faunadb/values/Metrics.scala

-2
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,10 @@ object Metrics extends Enumeration {
1010
val QueryBytesIn = Value("x-query-bytes-in")
1111
val QueryBytesOut = Value("x-query-bytes-out")
1212
val QueryTime = Value("x-query-time")
13-
val ReadOps = Value("x-read-ops")
1413
val StorageBytesRead = Value("x-storage-bytes-read")
1514
val StorageBytesWrite = Value("x-storage-bytes-write")
1615
val TxnRetries = Value("x-txn-retries")
1716
val TxnTime = Value("x-txn-time")
18-
val WriteOps = Value("x-write-ops")
1917

2018
val All = values.toList
2119
}

faunadb-scala/src/test/scala/faunadb/ClientSpec.scala

+1-5
Original file line numberDiff line numberDiff line change
@@ -524,12 +524,10 @@ class ClientSpec
524524
val queryBytesIn = metricsResponse.getMetric(Metrics.QueryBytesIn)
525525
val queryBytesOut = metricsResponse.getMetric(Metrics.QueryBytesOut)
526526
val queryTime = metricsResponse.getMetric(Metrics.QueryTime)
527-
val readOps = metricsResponse.getMetric(Metrics.ReadOps)
528527
val storageBytesRead = metricsResponse.getMetric(Metrics.StorageBytesRead)
529528
val storageBytesWrite = metricsResponse.getMetric(Metrics.StorageBytesWrite)
530529
val txnRetries = metricsResponse.getMetric(Metrics.TxnRetries)
531530
val txnTime = metricsResponse.getMetric(Metrics.TxnTime)
532-
val writeOps = metricsResponse.getMetric(Metrics.WriteOps)
533531

534532
byteReadOps.isDefined should equal (true)
535533
byteWriteOps.isDefined should equal (true)
@@ -538,12 +536,10 @@ class ClientSpec
538536
queryBytesIn.isDefined should equal (true)
539537
queryBytesOut.isDefined should equal (true)
540538
queryTime.isDefined should equal (true)
541-
readOps.isDefined should equal (true)
542539
storageBytesRead.isDefined should equal (true)
543540
storageBytesWrite.isDefined should equal (true)
544541
txnRetries.isDefined should equal (true)
545542
txnTime.isDefined should equal (true)
546-
writeOps.isDefined should equal (true)
547543
}
548544

549545
it should "paginate with cursor object" in {
@@ -2163,7 +2159,7 @@ class ClientSpec
21632159
it should "stream return error if the query is not readonly" in {
21642160
val err = client.stream(Create(Collection("spells"), Obj("data" -> Obj("testField" -> "testValue0")))).failed.futureValue
21652161
err shouldBe a[BadRequestException]
2166-
err.getMessage should include("Write effect in read-only query expression.")
2162+
err.getMessage should include("Call performs a write, which is not allowed in stream requests.")
21672163
}
21682164

21692165
it should "stream on document reference contains `document` field by default" in {

0 commit comments

Comments
 (0)