Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top bar elements persisting when navigating between panels in SPA mode #15982

Open
binaryfire opened this issue Apr 1, 2025 · 4 comments
Open

Comments

@binaryfire
Copy link
Contributor

binaryfire commented Apr 1, 2025

Package

filament/filament

Package Version

3.3.7

Laravel Version

12

Livewire Version

3.6.2

PHP Version

8.4

Problem description

When SPA mode is enabled, top bar elements are persisted when navigating between panels. In the example below the user menu, search field and db notification icon from the /admin panel remain on screen after navigating to the /test/ panel. They only disappear after a browser reload:

360p_kFoF.mp4

The issue is occurring with any top bar elements added via render hooks too.

Steps to reproduce

  1. Download the reproduction repo
  2. Go to the /admin dashboard
  3. Open the user menu and click "Test panel" to navigate to the /test panel.
  4. The admin panel's top bar elements will be persisted until the browser is reloaded

Reproduction repository (issue will be closed if this is not valid)

https://github.com/binaryfire/filament-multi-panel-spa-mode-bug

Copy link

github-actions bot commented Apr 1, 2025

Hey @binaryfire! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 1, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Apr 1, 2025
@binaryfire
Copy link
Contributor Author

@danharrin I included a reproduction repository URL. This shouldn't have been closed.

@binaryfire
Copy link
Contributor Author

Hey @binaryfire! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

@github-actions If you want to be successful when you try and overthrow your human overlords, you should really learn to read.

@danharrin
Copy link
Member

You changed the structure of the issue template in your edits, so its not able to keep track of its validity

@danharrin danharrin reopened this Apr 1, 2025
@github-project-automation github-project-automation bot moved this from Done to Todo in Roadmap Apr 1, 2025
@danharrin danharrin added this to the v3 milestone Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants