Skip to content

Commit 594b4c8

Browse files
Merge pull request #16 from fivetran/bugfix/country-long-test-addition
bugfix/country-long-test-addition
2 parents aa7913c + ed837d9 commit 594b4c8

10 files changed

+23
-15
lines changed

.buildkite/pipeline.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ steps:
5858
commands: |
5959
bash .buildkite/scripts/run_models.sh redshift
6060
61-
- label: ":bricks: Run Tests - Databricks"
61+
- label: ":databricks: Run Tests - Databricks"
6262
key: "run_dbt_databricks"
6363
plugins:
6464
- docker#v3.13.0:

CHANGELOG.md

+5
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
# dbt_app_reporting v0.3.1
2+
## Bug Fixes
3+
[PR #16](https://github.com/fivetran/dbt_app_reporting/pull/16) includes the following bug fix.
4+
- Included the `country_long` field in the unique combination of columns test for the `app_reporting__country_report`. It has been identified that Apple will sometimes provide records with different `country_long` names; however, they will be the same `country_short`. This is due to some countries having multiple `country_long` spelling variations.
5+
16
# dbt_app_reporting v0.3.0
27

38
## Bug Fixes:

dbt_project.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: 'app_reporting'
2-
version: '0.3.0'
2+
version: '0.3.1'
33
config-version: 2
44
models:
55
app_reporting:

docs/catalog.json

+1-1
Large diffs are not rendered by default.

docs/manifest.json

+1-1
Large diffs are not rendered by default.

docs/run_results.json

+1-1
Large diffs are not rendered by default.

integration_tests/ci/sample.profiles.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ integration_tests:
1616
pass: "{{ env_var('CI_REDSHIFT_DBT_PASS') }}"
1717
dbname: "{{ env_var('CI_REDSHIFT_DBT_DBNAME') }}"
1818
port: 5439
19-
schema: app_reporting_integrations_test_1
19+
schema: app_reporting_integrations_test_2
2020
threads: 8
2121
bigquery:
2222
type: bigquery
2323
method: service-account-json
2424
project: 'dbt-package-testing'
25-
schema: app_reporting_integrations_test_1
25+
schema: app_reporting_integrations_test_2
2626
threads: 8
2727
keyfile_json: "{{ env_var('GCLOUD_SERVICE_KEY') | as_native }}"
2828
snowflake:
@@ -33,7 +33,7 @@ integration_tests:
3333
role: "{{ env_var('CI_SNOWFLAKE_DBT_ROLE') }}"
3434
database: "{{ env_var('CI_SNOWFLAKE_DBT_DATABASE') }}"
3535
warehouse: "{{ env_var('CI_SNOWFLAKE_DBT_WAREHOUSE') }}"
36-
schema: app_reporting_integrations_test_1
36+
schema: app_reporting_integrations_test_2
3737
threads: 8
3838
postgres:
3939
type: postgres
@@ -42,13 +42,13 @@ integration_tests:
4242
pass: "{{ env_var('CI_POSTGRES_DBT_PASS') }}"
4343
dbname: "{{ env_var('CI_POSTGRES_DBT_DBNAME') }}"
4444
port: 5432
45-
schema: app_reporting_integrations_test_1
45+
schema: app_reporting_integrations_test_2
4646
threads: 8
4747
databricks:
4848
catalog: null
4949
host: "{{ env_var('CI_DATABRICKS_DBT_HOST') }}"
5050
http_path: "{{ env_var('CI_DATABRICKS_DBT_HTTP_PATH') }}"
51-
schema: app_reporting_integrations_test_1
52-
threads: 2
51+
schema: app_reporting_integrations_test_2
52+
threads: 8
5353
token: "{{ env_var('CI_DATABRICKS_DBT_TOKEN') }}"
5454
type: databricks

integration_tests/dbt_project.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
name: 'app_reporting_integration_tests'
2-
version: '0.3.0'
2+
version: '0.3.1'
33
profile: 'integration_tests'
44
config-version: 2
55

66
vars:
7-
google_play_schema: app_reporting_integrations_test_1
8-
apple_store_schema: app_reporting_integrations_test_1
7+
google_play_schema: app_reporting_integrations_test_2
8+
apple_store_schema: app_reporting_integrations_test_2
99
google_play_source:
1010
stats_installs_app_version_identifier: "stats_installs_app_version"
1111
stats_crashes_app_version_identifier: "stats_crashes_app_version"

integration_tests/seeds/app_store_territory_source_type.csv

+3-1
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,6 @@ app_id,date,source_type,territory,meets_threshold,impressions,_fivetran_synced,i
1313
12345,2021-11-24 00:00:00+00:00,App Store Search,Kosovo,True,0,2022-01-02 12:34:56.789000+00:00,0,0,3
1414
12345,2021-10-24 00:00:00+00:00,App Store Search,Côte d'Ivoire,True,0,2022-01-02 12:34:56.789000+00:00,0,0,3
1515
12345,2021-10-26 00:00:00+00:00,App Store Search,Cote d'Ivoire,True,0,2022-01-02 12:34:56.789000+00:00,0,0,3
16-
12345,2021-11-26 00:00:00+00:00,App Store Search,Cote d'Ivoire,True,0,2022-01-02 12:34:56.789000+00:00,0,0,3
16+
12345,2021-11-26 00:00:00+00:00,App Store Search,Cote d'Ivoire,True,0,2022-01-02 12:34:56.789000+00:00,0,0,3
17+
12345,2021-11-26 00:00:00+00:00,App Store Search,Turkey,True,0,2022-01-02 12:34:56.789000+00:00,0,0,3
18+
12345,2021-11-26 00:00:00+00:00,App Store Search,Türkiye,True,0,2022-01-02 12:34:56.789000+00:00,0,0,3

models/app_reporting.yml

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ models:
3535
- app_platform
3636
- app_name
3737
- country_short
38+
- country_long
3839
columns:
3940
- name: date_day
4041
description: '{{ doc("date_day") }}'

0 commit comments

Comments
 (0)