Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake errors with cmake 4.0 #10157

Open
patrick-stephens opened this issue Apr 1, 2025 · 5 comments · May be fixed by #10178
Open

CMake errors with cmake 4.0 #10157

patrick-stephens opened this issue Apr 1, 2025 · 5 comments · May be fixed by #10178

Comments

@patrick-stephens
Copy link
Contributor

E.g. 2/3 jobs are fine here: https://github.com/fluent/fluent-bit/actions/runs/14193264266/job/39762617728

The other fails with Compatibility with CMake < 3.5 has been removed from CMake. in the vcpkg build of libyaml (which is indeed specifying 3.0 as the minimum).

Separately should we vendor in libyaml instead?

@patrick-stephens
Copy link
Contributor Author

Related to this: microsoft/vcpkg#44726

Potentially down to us using a local vcpkg version as well as installing a version via devtools - path resolution may be different for each build and therefore picking up a different version.

@patrick-stephens
Copy link
Contributor Author

I think this is down to the recent cmake 4.0 release requiring the change but still rolling out to be picked up by builder images so is intermittent. It will become consistent though.

@patrick-stephens patrick-stephens changed the title ci: CMake errors intermittently for Windows builds CMake errors with cmake 4.0 Apr 2, 2025
@patrick-stephens
Copy link
Contributor Author

This will start impacting all builds and CI (e.g. unit tests) shortly as CMake 4.0 packages roll out to affected targets. Easiest solution for now is to pin CMake to 3.x series on affected workflows and document this too.

@ThomasDevoogdt
Copy link
Contributor

This is not a really durable fix, adapting the CMakeLists.txt files is unavoidable. Also buildroot will likely have troubles soon.

I had also the same problem here:#9277

The only work flow that passed is mine, since I forced it.

@patrick-stephens
Copy link
Contributor Author

Agreed, the issue though as well is some of the dependencies also need updates and not all of those are vendored in. Libyaml builds were failing on Windows via vcpkg for example and we have no control over that.

Main goal was to mitigate by unblocking first and then resolve properly. It likely will need releases from the downstream dependencies we will need to consume.

@mabrarov mabrarov linked a pull request Apr 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants