From b3f791eb4c1c235ce233a9360f96f4ed23687e73 Mon Sep 17 00:00:00 2001 From: Anuj Singh Date: Tue, 18 Mar 2025 11:07:14 -0700 Subject: [PATCH] out_s3: clarify comment about sending chunks Signed-off-by: Anuj Singh --- plugins/out_s3/s3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/out_s3/s3.c b/plugins/out_s3/s3.c index 3b1edafbdab..e396377dfec 100644 --- a/plugins/out_s3/s3.c +++ b/plugins/out_s3/s3.c @@ -928,7 +928,7 @@ static int cb_s3_init(struct flb_output_instance *ins, /* * S3 must ALWAYS use sync mode - * In the timer thread we do a mk_list_foreach_safe on the queue of uplaods and chunks + * In the timer thread we do a mk_list_foreach_safe on the queue of uploads and chunks * Iterating over those lists is not concurrent safe. If a flush call ran at the same time * And deleted an item from the list, this could cause a crash/corruption. */ @@ -1779,7 +1779,7 @@ static void cb_s3_upload(struct flb_config *config, void *data) chunk = fsf->data; if (now < (chunk->create_time + ctx->upload_timeout + ctx->retry_time)) { - continue; /* Only send chunks which have timed out */ + continue; /* Only send chunks which haven't timed out */ } /* Locked chunks are being processed, skip */