Some more pylint fun

Author: flyte

.pylintrc

@@ -2,4 +2,6 @@
 disable=
     too-many-arguments,
     unused-argument,
-    duplicate-code
+    duplicate-code,
+    consider-using-f-string,
+    consider-using-from-import

mqtt_io/__main__.py

@@ -20,7 +20,7 @@
 from .modules import install_missing_requirements
 from .server import MqttIo
 
-_LOG = logging.getLogger('mqtt_io.__main__')
+_LOG = logging.getLogger("mqtt_io.__main__")
 
 
 def hashed(value: Any) -> str:
@@ -49,7 +49,7 @@ def load_config(config: str, render_config: str) -> Any:
     """
     Loads the config, and uses confp to render it if necessary.
     """
-    with open(config, "r") as stream:
+    with open(config, "r", encoding="utf8") as stream:
         if render_config:
             rendered = render(render_config, stream.read())
             raw_config = yaml.safe_load(rendered)
@@ -64,10 +64,13 @@ def main() -> None:
     """
     parser = argparse.ArgumentParser()
     parser.add_argument("config")
-    parser.add_argument("--render", help="""
+    parser.add_argument(
+        "--render",
+        help="""
     A config file for confp for preprocessing the config file.
     Doesn't need to contain a template section.
-    """)
+    """,
+    )
     args = parser.parse_args()
 
     # Load, validate and normalise config, or quit.
@@ -103,7 +106,7 @@ def main() -> None:
         mqtt_gpio = MqttIo(config)
         mqtt_gpio.run()
     except Exception:
-        _LOG.exception('MqttIo crashed!')
+        _LOG.exception("MqttIo crashed!")
         raise
 
 

mqtt_io/config/__init__.py

@@ -74,7 +74,7 @@ def get_main_schema() -> ConfigType:
     :rtype: dict
     """
     schema_path = join(dirname(realpath(__file__)), "config.schema.yml")
-    with open(schema_path) as schema_file:
+    with open(schema_path, encoding="utf8") as schema_file:
         # We write this schema file, so we know it'll adhere to ConfigType rules
         return cast(ConfigType, yaml.safe_load(schema_file))
 
@@ -172,7 +172,7 @@ def load_main_config(path: str) -> ConfigType:
     :param path: The filesystem path
     :return: The config
     """
-    with open(path, "r") as stream:
+    with open(path, "r", encoding="utf8") as stream:
         raw_config = yaml.safe_load(stream)
     return validate_and_normalise_main_config(raw_config)
 

mqtt_io/mqtt/__init__.py

@@ -147,7 +147,8 @@ async def publish(self, msg: MQTTMessageSend) -> None:
         Publish an MQTT message.
         """
 
-    @abc.abstractproperty
+    @property
+    @abc.abstractmethod
     def message_queue(self) -> "asyncio.Queue[MQTTMessage]":
         """
         Get the queue onto which received MQTT messages are put.