Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column 'marks_out_of' cannot be null in patch #1400

Open
hasanmfd opened this issue Mar 26, 2025 · 0 comments
Open

Column 'marks_out_of' cannot be null in patch #1400

hasanmfd opened this issue Mar 26, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@hasanmfd
Copy link

After Upgrade lms from v1 to v2

The issue is from the patch file :
lms.patches.v2_0.update_quiz_submission_data

Expected behavior
Bench migrate is not completely done.

This is the code :
I believe need to check marks_out_of for possible null:

	for question in questions:
		if question.question_name:
			marks_out_of = frappe.db.get_value(
				"LMS Quiz Question",
				{"parent": submission.quiz, "question": question.question_name},
				["marks"],
			)

			frappe.db.set_value(
				"LMS Quiz Result",
				{"parent": submission.name, "question_name": question.question_name},
				"marks_out_of",
				marks_out_of,
			)
@hasanmfd hasanmfd added the bug Something isn't working label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant