[Zoo Parade] Bugs

[Spooky-0]

1. Values should be 1-5 not 0-4 Resolved in [Zooparade] Card values should be 1-5 (not 0-4) #619
2. When a player recieves a nr/clr hint, all boxes should be black except for the truth. E.g. You know you have a 2, then you should see [ ] [2] [ ] [ ] [ ]... currently you see [1] [2] [3] [4] [5]
3. Colors of the little squares need to be same as the cards ( I added a text file to the media folder with the cards. There is a link to the color pallet)
4. As alraedy known, the little boxes overlap the cards.

[jasonharrison]

Would you please split these up into individual GitHub issues? This will be easier to track.

[DanielSherlock]

1. Further resolved by Fixed Numbering Throughout Zoo Parade #623

[DanielSherlock]

2. Will be sorted by Zoo parade smarter hints #624, once the corresponding tests are written.

[DanielSherlock]

3. I think we just need to change the colors array in web/src/games/zooparade/components/bhinticon.tsx?

[DanielSherlock]

4. Wait, was that an issue? I thought that was the way you lot had decided on to make it looked less cluttered. I kinda liked it. Where do you want them to be instead?

[Spooky-0]

4. Wait, was that an issue? I thought that was the way you lot had decided on to make it looked less cluttered. I kinda liked it. Where do you want them to be instead?

Yes. But then I redesigned the cards and now they have a different ratio. They are a bit shorter. And consequently some hintsquares are below the card.

[vdfdev]

I think all the 4 issues are resolved now? But I found some more playing with friends today:

• The deck went to -3 instead of (game over?)

• (mobile) The top deck being built didn't fit on my phone, so one card wrapped in a new line. Even though the players decks with the same number of cards did fit.

• (mobile) There was no padding on the top of the page, so the FBG bar was hiding half the cards of the top deck

• (mobile) there was no padding on the bottom of the page, so the android menu was hiding half the buttons

[DanielSherlock]

(mobile) There was no padding on the top of the page, so the FBG bar was hiding half the cards of the top deck

(mobile) there was no padding on the bottom of the page, so the android menu was hiding half the buttons

Was something done about this? I ask because last time I played a game I had a different bug with the padding (though one of my friends, on a different OS&browser, didn't) which made the log unviewable, and wondered whether it was introduced recently. There were also other, even more important bugs I want to deal with soon, but I feel like the proper thing to do is to open a new issue for each bug?

If those-in-charge are happy for me to try and tidy up all the Zoo Parade issues, that could be a sensible first step?

[vdfdev]

@DanielSherlock yes, I think I sent a PR to fix these bugs you mention.

Tidying up the issues would be very welcomed !

[vdfdev]

@DanielSherlock you should have access on github to manage issues already :)

[DanielSherlock]

Hello all,

It's been a while, but here's what I think the state of all the bugs in Zoo Parade is:

• Of the original 4 bugs mentioned in this issue:
  1. Was solved by [Zooparade] Card values should be 1-5 #620 and Fixed Numbering Throughout Zoo Parade #623
  2. Feature was added in Zoo parade smarter hints #624
  3. @vdfdev thinks this is solved: looks like this was fixed with Fbgio #630
  4. As above: it looks like this was patched in Fix numbers on Zooparade cards #617
• Of the issues identified by @vdfdev:
  • The first one has been fixed in Fbgio #630 by showing the "empty" card, but a related bug remains - see the new issue [Zoo Parade] Player sees phantom cards at end of game #865.
  • The second is still around in at least some form: (At some screen sizes) the cards in the hands squish up and slightly overflow the screen. The layout piles at the top still wrap onto a new line. I think all this might be because, when the size of the cards was changed, it wasn't changed everywhere (maybe?) so this might still be fixable by going through the code and making sure all the sizes are consistent. If not, it'll need a deeper look at the CSS. For now, as it seems to happen very very rarely, and doesn't affect the game, I'm planning on ignoring it until more fundamental layout problems (e.g. [Zoo Parade] Top-Bar Unresponsive in Some Browsers #868) have been addressed and I know what's going on.
  • The others I haven't been able to test, but as @vdfdev says, should be resolved in Fbgio #630, specifically this commit (at least, it's seems like that's what those changes are doing).
• The issue I mentioned, and the others I alluded to are similarly unresolved and now also have their own issues: see [Zoo Parade] Game Info Could do with Updating #866, [Zoo Parade] Player Can't Give Hints at End of Game #867, and [Zoo Parade] Top-Bar Unresponsive in Some Browsers #868.
• For completeness, I'll also mention that the important (if we want to keep to the rules of Hanabi) missing feature in [Zoo Parade] Should be able to see trash #615 remains unimplemented.

As I've now accounted for all the various known bugs and separately replaced those that are still a problem, I'm now going to close this issue.

[vdfdev]

Thanks for reviewing and organizing this!

…

On Tue, May 18, 2021, 2:28 PM Daniel Sherlock ***@***.***> wrote: Closed #614 <#614>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#614 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAH4TB5J4Q6COOAJLPDL4A3TOLLWZANCNFSM4PFBTBJQ> .