Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global feedback #6

Closed
Girardvjonathan opened this issue Dec 5, 2017 · 3 comments
Closed

Global feedback #6

Girardvjonathan opened this issue Dec 5, 2017 · 3 comments

Comments

@Girardvjonathan
Copy link

Girardvjonathan commented Dec 5, 2017

Currently global feedback (Rétroaction générale) don't get parsed (in numerical questions at least).

GIFT:

// question: 229196  name: Test Numerical
::Test Numerical::Whats two plus 4?{#
	=%100%6:0#Good job its really 6!
	####2+4 \= 6
}

Result

Line 2, column 36: Expected {#... }, {= match1 -> Match1 ...}, {=correct choice ~incorrect choice ... }, or {T} or {F} or {True} or {False} but "{" found.

Expected

[
   {
      "type": "Numerical",
      "title": "Test Numerical",
      "stem": "Whats two plus 4?",
      "hasEmbeddedAnswers": false,
      "choices": [
         {
            "isCorrect": true,
            "weight": 100,
            "text": {
               "type": "range",
               "number": 6,
               "range": 0
            },
            "feedback": "Good job its really 6!",
            "globalFeedBack": "2+4 = 6"
         }
      ]
   }
]

On my side this issues don't need to be fixed. Just wanted to notify you.

@fuhrmanator
Copy link
Owner

Thanks for the bug and the expected output. It looks like you generated this question by exporting a Moodle question to GIFT. Can you confirm that's how you did it? There are no examples on the web that I've found so far.

General feedback isn't parsed at all for now. I added the check box to #1

@Girardvjonathan
Copy link
Author

Yes, it was exported from Moodle question to GIFT.

@fuhrmanator
Copy link
Owner

Fixed in #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants