Skip to content

Commit 084840e

Browse files
committed
don't use acronym, keep flake8 happy
1 parent 89b3f1a commit 084840e

File tree

5 files changed

+18
-19
lines changed

5 files changed

+18
-19
lines changed

errata/sources/distros/centos.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
# along with Patchman. If not, see <http://www.gnu.org/licenses/>
1616

1717
import re
18-
from defusedxml import ElementTree as ET
18+
from defusedxml import ElementTree
1919

2020
from operatingsystems.utils import get_or_create_osrelease
2121
from packages.models import Package
@@ -65,7 +65,7 @@ def parse_centos_errata_checksum(data):
6565
def parse_centos_errata(data):
6666
""" Parse CentOS errata from https://cefs.steve-meier.de/
6767
"""
68-
result = ET.XML(data)
68+
result = ElementTree.XML(data)
6969
errata_xml = result.findall('*')
7070
elen = len(errata_xml)
7171
pbar_start.send(sender=None, ptext=f'Processing {elen} CentOS Errata', plen=elen)

errata/sources/repos/yum.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
import concurrent.futures
1818
from io import BytesIO
19-
import defusedxml.ElementTree as ET
19+
from defusedxml import ElementTree
2020

2121
from operatingsystems.utils import get_or_create_osrelease
2222
from packages.models import Package
@@ -30,11 +30,11 @@ def extract_updateinfo(data, url, concurrent_processing=True):
3030
"""
3131
extracted = extract(data, url)
3232
try:
33-
tree = ET.parse(BytesIO(extracted))
33+
tree = ElementTree.parse(BytesIO(extracted))
3434
root = tree.getroot()
3535
elen = root.__len__()
3636
updates = root.findall('update')
37-
except ET.ParseError as e:
37+
except ElementTree.ParseError as e:
3838
error_message.send(sender=None, text=f'Error parsing updateinfo file from {url} : {e}')
3939
if concurrent_processing:
4040
extract_updateinfo_concurrently(updates, elen)

repos/repo_types/gentoo.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import shutil
2121
import tarfile
2222
import tempfile
23-
from defusedxml import ElementTree as ET
23+
from defusedxml import ElementTree
2424
from fnmatch import fnmatch
2525
from io import BytesIO
2626

@@ -94,7 +94,7 @@ def get_gentoo_overlay_mirrors(repo_name):
9494
return
9595
mirrors = []
9696
try:
97-
tree = ET.parse(BytesIO(res.content))
97+
tree = ElementTree.parse(BytesIO(res.content))
9898
root = tree.getroot()
9999
for child in root:
100100
if child.tag == 'repo':
@@ -105,7 +105,7 @@ def get_gentoo_overlay_mirrors(repo_name):
105105
if found and element.tag == 'source':
106106
if element.text.startswith('http'):
107107
mirrors.append(element.text)
108-
except ET.ParseError as e:
108+
except ElementTree.ParseError as e:
109109
error_message.send(sender=None, text=f'Error parsing {gentoo_overlays_url}: {e}')
110110
return mirrors
111111

@@ -119,7 +119,7 @@ def get_gentoo_mirror_urls():
119119
return
120120
mirrors = {}
121121
try:
122-
tree = ET.parse(BytesIO(res.content))
122+
tree = ElementTree.parse(BytesIO(res.content))
123123
root = tree.getroot()
124124
for child in root:
125125
if child.tag == 'mirrorgroup':
@@ -139,7 +139,7 @@ def get_gentoo_mirror_urls():
139139
elif element.tag == 'uri':
140140
if element.get('protocol') == 'http':
141141
mirrors[name]['urls'].append(element.text)
142-
except ET.ParseError as e:
142+
except ElementTree.ParseError as e:
143143
error_message.send(sender=None, text=f'Error parsing {gentoo_distfiles_url}: {e}')
144144
mirror_urls = []
145145
# for now, ignore region data and choose MAX_MIRRORS mirrors at random

repos/repo_types/yum.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
import re
1818
import yaml
19-
from defusedxml import ElementTree as ET
19+
from defusedxml import ElementTree
2020
from io import BytesIO
2121

2222
from errata.sources.repos.yum import extract_updateinfo
@@ -39,7 +39,7 @@ def get_repomd_url(mirror_url, data, url_type='primary'):
3939
extracted = extract(data, mirror_url)
4040
location = None
4141
try:
42-
tree = ET.parse(BytesIO(extracted))
42+
tree = ElementTree.parse(BytesIO(extracted))
4343
root = tree.getroot()
4444
for child in root:
4545
if child.attrib.get('type') == url_type:
@@ -49,7 +49,7 @@ def get_repomd_url(mirror_url, data, url_type='primary'):
4949
if grandchild.tag == f'{{{ns}}}checksum':
5050
checksum = grandchild.text
5151
checksum_type = grandchild.attrib.get('type')
52-
except ET.ParseError as e:
52+
except ElementTree.ParseError as e:
5353
error_message.send(sender=None, text=(f'Error parsing repomd from {mirror_url}: {e}'))
5454
if not location:
5555
return None, None, None
@@ -110,7 +110,7 @@ def extract_yum_packages(data, url):
110110
ns = 'http://linux.duke.edu/metadata/common'
111111
packages = set()
112112
try:
113-
context = ET.iterparse(BytesIO(extracted), events=('start', 'end'))
113+
context = ElementTree.iterparse(BytesIO(extracted), events=('start', 'end'))
114114
for event, elem in context:
115115
if event == 'start':
116116
if elem.tag == f'{{{ns}}}metadata':
@@ -152,7 +152,7 @@ def extract_yum_packages(data, url):
152152
text = f'Error parsing Package: {name} {epoch} {version} {release} {arch}'
153153
error_message.send(sender=None, text=text)
154154
elem.clear()
155-
except ET.ParseError as e:
155+
except ElementTree.ParseError as e:
156156
error_message.send(sender=None, text=f'Error parsing yum primary.xml from {url}: {e}')
157157
return packages
158158

repos/utils.py

+3-4
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@
1717

1818
import re
1919
from io import BytesIO
20-
21-
from defusedxml import ElementTree as ET
20+
from defusedxml import ElementTree
2221
from tenacity import RetryError
2322

2423
from django.db import IntegrityError
@@ -121,7 +120,7 @@ def get_metalink_urls(url):
121120
extracted = extract(data, url)
122121
ns = 'http://www.metalinker.org/'
123122
try:
124-
tree = ET.parse(BytesIO(extracted))
123+
tree = ElementTree.parse(BytesIO(extracted))
125124
root = tree.getroot()
126125
for child in root:
127126
if child.tag == f'{{{ns}}}files':
@@ -133,7 +132,7 @@ def get_metalink_urls(url):
133132
if greatgreatgrandchild.tag == f'{{{ns}}}url':
134133
if greatgreatgrandchild.attrib.get('protocol') in ['https', 'http']:
135134
metalink_urls.append(greatgreatgrandchild.text)
136-
except ET.ParseError as e:
135+
except ElementTree.ParseError as e:
137136
error_message.send(sender=None, text=f'Error parsing metalink {url}: {e}')
138137
return metalink_urls
139138

0 commit comments

Comments
 (0)