Skip to content

Commit 807fa43

Browse files
ankatiyarmerelcht
authored andcommitted
refactor(datasets): Move NetCDFDataset to experimental (kedro-org#739)
* Move NetCDFDataset to experimental Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * release notes and fix reqs Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> * Docs test Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> --------- Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com> Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
1 parent 7fb97d2 commit 807fa43

File tree

9 files changed

+10
-8
lines changed

9 files changed

+10
-8
lines changed

kedro-datasets/RELEASE.md

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99
| `langchain.ChatCohereDataset` | A dataset for loading a ChatCohere langchain model. | `kedro_datasets_experimental.langchain` |
1010
| `langchain.OpenAIEmbeddingsDataset` | A dataset for loading a OpenAIEmbeddings langchain model. | `kedro_datasets_experimental.langchain` |
1111
| `langchain.ChatOpenAIDataset` | A dataset for loading a ChatOpenAI langchain model. | `kedro_datasets_experimental.langchain` |
12+
| `netcdf.NetCDFDataset` | A dataset for loading and saving "*.nc" files. | `kedro_datasets_experimental.netcdf` |
13+
* `netcdf.NetCDFDataset` moved from `kedro_datasets` to `kedro_datasets_experimental`.
1214
* Extended preview feature to `yaml.YAMLDataset`.
1315

1416
## Community contributions

kedro-datasets/docs/source/api/kedro_datasets.rst

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ kedro_datasets
2424
kedro_datasets.json.JSONDataset
2525
kedro_datasets.matlab.MatlabDataset
2626
kedro_datasets.matplotlib.MatplotlibWriter
27-
kedro_datasets.netcdf.NetCDFDataset
2827
kedro_datasets.networkx.GMLDataset
2928
kedro_datasets.networkx.GraphMLDataset
3029
kedro_datasets.networkx.JSONDataset

kedro-datasets/docs/source/api/kedro_datasets_experimental.rst

+1
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,4 @@ kedro_datasets_experimental
1515
kedro_datasets_experimental.langchain.ChatCohereDataset
1616
kedro_datasets_experimental.langchain.ChatOpenAIDataset
1717
kedro_datasets_experimental.langchain.OpenAIEmbeddingsDataset
18+
kedro_datasets_experimental.netcdf.NetCDFDataset

kedro-datasets/kedro_datasets_experimental/tests/netcdf/__init__.py

Whitespace-only changes.

kedro-datasets/tests/netcdf/test_netcdf_dataset.py kedro-datasets/kedro_datasets_experimental/tests/netcdf/test_netcdf_dataset.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from s3fs import S3FileSystem
99
from xarray.testing import assert_equal
1010

11-
from kedro_datasets.netcdf import NetCDFDataset
11+
from kedro_datasets_experimental.netcdf import NetCDFDataset
1212

1313
FILE_NAME = "test.nc"
1414
MULTIFILE_NAME = "test*.nc"

kedro-datasets/pyproject.toml

+6-6
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,6 @@ matlab = ["kedro-datasets[matlab-matlabdataset]"]
8080
matplotlib-matplotlibwriter = ["matplotlib>=3.0.3, <4.0"]
8181
matplotlib = ["kedro-datasets[matplotlib-matplotlibwriter]"]
8282

83-
netcdf-netcdfdataset = ["h5netcdf>=1.2.0","netcdf4>=1.6.4","xarray>=2023.1.0"]
84-
netcdf = ["kedro-datasets[netcdf-netcdfdataset]"]
85-
8683
networkx-gmldataset = ["kedro-datasets[networkx-base]"]
8784
networkx-graphmldataset = ["kedro-datasets[networkx-base]"]
8885
networkx-jsondataset = ["kedro-datasets[networkx-base]"]
@@ -172,6 +169,8 @@ langchain-openaiembeddingsdataset = ["langchain-openai~=0.1.7"]
172169
langchain-chatanthropicdataset = ["langchain-anthropic~=0.1.13", "langchain-community~=0.2.0"]
173170
langchain-chatcoheredataset = ["langchain-cohere~=0.1.5", "langchain-community~=0.2.0"]
174171
langchain = ["kedro-datasets[langchain-chatopenaidataset,langchain-openaiembeddingsdataset,langchain-chatanthropicdataset,langchain-chatcoheredataset ]"]
172+
netcdf-netcdfdataset = ["h5netcdf>=1.2.0","netcdf4>=1.6.4","xarray>=2023.1.0"]
173+
netcdf = ["kedro-datasets[netcdf-netcdfdataset]"]
175174

176175
# Docs requirements
177176
docs = [
@@ -200,7 +199,6 @@ test = [
200199
"geopandas>=0.6.0, <1.0",
201200
"hdfs>=2.5.8, <3.0",
202201
"holoviews>=1.13.0",
203-
"h5netcdf>=1.2.0",
204202
"ibis-framework[duckdb,examples]",
205203
"import-linter[toml]==1.2.6",
206204
"ipython>=7.31.1, <8.0",
@@ -214,7 +212,6 @@ test = [
214212
"memory_profiler>=0.50.0, <1.0",
215213
"moto==5.0.0",
216214
"mypy~=1.0",
217-
"netcdf4>=1.6.4",
218215
"networkx~=2.4",
219216
"opencv-python~=4.5.5.64",
220217
"openpyxl>=3.0.3, <4.0",
@@ -273,6 +270,9 @@ experimental = [
273270
"langchain-cohere",
274271
"langchain-anthropic",
275272
"langchain-community",
273+
"h5netcdf>=1.2.0",
274+
"netcdf4>=1.6.4",
275+
"xarray>=2023.1.0",
276276
]
277277

278278
# All requirements
@@ -294,7 +294,7 @@ version = {attr = "kedro_datasets.__version__"}
294294
fail_under = 100
295295
show_missing = true
296296
# temporarily ignore kedro_datasets/__init__.py in coverage report
297-
omit = ["tests/*", "kedro_datasets/holoviews/*", "kedro_datasets/netcdf/*", "kedro_datasets/snowflake/*", "kedro_datasets/tensorflow/*", "kedro_datasets/__init__.py", "kedro_datasets/conftest.py"]
297+
omit = ["tests/*", "kedro_datasets/holoviews/*", "kedro_datasets/snowflake/*", "kedro_datasets/tensorflow/*", "kedro_datasets/__init__.py", "kedro_datasets/conftest.py"]
298298
exclude_also = ["raise NotImplementedError", "if TYPE_CHECKING:"]
299299

300300
[tool.pytest.ini_options]

0 commit comments

Comments
 (0)