(chocolateyGH-1038) Add ability to stop operation on reboot

There is now both a parameter and a feature flag which will allow
halting the install/upgrade/uninstall of a package, when a reboot
request is returned from one of it's dependencies.

When this occurs, an ApplicationException will be thrown, and the
package exit code, either 1641 (restart initiated), or 3010 (restart
requested) will be returned.  This could then be inspected to decide
when a reboot should actually be performed, before continuing with
the remainder of the installation.

The implementation of this ability followed closely to how the
stoponfirstfailure parameter and feature flag are implemented.

Author: gep13

src/chocolatey/infrastructure.app/ApplicationParameters.cs

@@ -170,6 +170,7 @@ public static class Features
             public static readonly string IgnoreUnfoundPackagesOnUpgradeOutdated = "ignoreUnfoundPackagesOnUpgradeOutdated";
             public static readonly string RemovePackageInformationOnUninstall = "removePackageInformationOnUninstall";
             public static readonly string LogWithoutColor = "logWithoutColor";
+            public static readonly string StopOnFirstPackageRebootRequest = "stopOnFirstPackageRebootRequest";
         }
 
         public static class Messages

src/chocolatey/infrastructure.app/builders/ConfigurationBuilder.cs

@@ -1,4 +1,4 @@
-// Copyright © 2017 - 2018 Chocolatey Software, Inc
+// Copyright © 2017 - 2018 Chocolatey Software, Inc
 // Copyright © 2011 - 2017 RealDimensions Software, LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
@@ -303,6 +303,7 @@ private static void set_feature_flags(ChocolateyConfiguration config, ConfigFile
 
             config.Features.ScriptsCheckLastExitCode = set_feature_flag(ApplicationParameters.Features.ScriptsCheckLastExitCode, configFileSettings, defaultEnabled: false, description: "Scripts Check $LastExitCode (external commands) - Leave this off unless you absolutely need it while you fix your package scripts  to use `throw 'error message'` or `Set-PowerShellExitCode #` instead of `exit #`. This behavior started in 0.9.10 and produced hard to find bugs. If the last external process exits successfully but with an exit code of not zero, this could cause hard to detect package failures. Available in 0.10.3+. Will be removed in 0.11.0.");
             config.PromptForConfirmation = !set_feature_flag(ApplicationParameters.Features.AllowGlobalConfirmation, configFileSettings, defaultEnabled: false, description: "Prompt for confirmation in scripts or bypass.");
+            config.Features.StopOnFirstPackageRebootRequest = set_feature_flag(ApplicationParameters.Features.StopOnFirstPackageRebootRequest, configFileSettings, defaultEnabled: false, description: "- stop running install, upgrade, or uninstall on first package reboot request instead of continuing with others.  As this will affect upgrade all, it is normally recommended to leave this off.  Available in 0.10.12+.");
         }
 
         private static bool set_feature_flag(string featureName, ConfigFileSettings configFileSettings, bool defaultEnabled, string description)

src/chocolatey/infrastructure.app/commands/ChocolateyInstallCommand.cs

@@ -155,6 +155,11 @@ public virtual void configure_argument_parser(OptionSet optionSet, ChocolateyCon
                      "Stop On First Package Failure - stop running install, upgrade or uninstall on first package failure instead of continuing with others. Overrides the default feature '{0}' set to '{1}'. Available in 0.10.4+.".format_with(ApplicationParameters.Features.StopOnFirstPackageFailure, configuration.Features.StopOnFirstPackageFailure.to_string()),
                      option => configuration.Features.StopOnFirstPackageFailure = option != null
                      )
+                 .Add("stoponfirstrebootrequest|stop-on-first-reboot-request|stop-on-first-package-reboot-request",
+                     "Stop On First Package Reboot Request - stop running install, upgrade, or uninstall on first package reboot request instead of continuing with others.  Overrides the default feature '{0}' set to '{1}'.  Available in 0.10.12+.".format_with
+                     (ApplicationParameters.Features.StopOnFirstPackageRebootRequest, configuration.Features.StopOnFirstPackageRebootRequest.to_string()),
+                     option => configuration.Features.StopOnFirstPackageRebootRequest = option != null
+                     )
                 ;
 
             //todo: package name can be a url / installertype

src/chocolatey/infrastructure.app/commands/ChocolateyUninstallCommand.cs

@@ -118,6 +118,11 @@ public virtual void configure_argument_parser(OptionSet optionSet, ChocolateyCon
                      "Stop On First Package Failure - stop running install, upgrade or uninstall on first package failure instead of continuing with others. Overrides the default feature '{0}' set to '{1}'. Available in 0.10.4+.".format_with(ApplicationParameters.Features.StopOnFirstPackageFailure, configuration.Features.StopOnFirstPackageFailure.to_string()),
                      option => configuration.Features.StopOnFirstPackageFailure = option != null
                      )
+                 .Add("stoponfirstrebootrequest|stop-on-first-reboot-request|stop-on-first-package-reboot-request",
+                     "Stop On First Package Reboot Request - stop running install, upgrade, or uninstall on first package reboot request instead of continuing with others.  Overrides the default feature '{0}' set to '{1}'.  Available in 0.10.12+.".format_with
+                     (ApplicationParameters.Features.StopOnFirstPackageRebootRequest, configuration.Features.StopOnFirstPackageRebootRequest.to_string()),
+                     option => configuration.Features.StopOnFirstPackageRebootRequest = option != null
+                     )
                 ;
         }
 

src/chocolatey/infrastructure.app/commands/ChocolateyUpgradeCommand.cs

@@ -182,6 +182,11 @@ public virtual void configure_argument_parser(OptionSet optionSet, ChocolateyCon
                     {
                         if (option != null) configuration.Features.UseRememberedArgumentsForUpgrades = false;
                     })
+                 .Add("stoponfirstrebootrequest|stop-on-first-reboot-request|stop-on-first-package-reboot-request",
+                     "Stop On First Package Reboot Request - stop running install, upgrade, or uninstall on first package reboot request instead of continuing with others.  Overrides the default feature '{0}' set to '{1}'.  Available in 0.10.12+.".format_with
+                     (ApplicationParameters.Features.StopOnFirstPackageRebootRequest, configuration.Features.StopOnFirstPackageRebootRequest.to_string()),
+                     option => configuration.Features.StopOnFirstPackageRebootRequest = option != null
+                     )
                 ;
         }
 

src/chocolatey/infrastructure.app/configuration/ChocolateyConfiguration.cs

@@ -390,6 +390,7 @@ public sealed class FeaturesConfiguration
         public bool UseRememberedArgumentsForUpgrades { get; set; }
         public bool IgnoreUnfoundPackagesOnUpgradeOutdated { get; set; }
         public bool RemovePackageInformationOnUninstall { get; set; }
+        public bool StopOnFirstPackageRebootRequest { get; set; }
 
         //todo remove in 0.11.0
         public bool ScriptsCheckLastExitCode { get; set; }

src/chocolatey/infrastructure.app/services/ChocolateyPackageService.cs

@@ -420,6 +420,19 @@ public void handle_package_result(PackageResult packageResult, ChocolateyConfigu
 
             remove_pending(packageResult, config);
 
+            // Test to see if exit code is either:
+            // 1641 - restart initiated
+            // 3010 - restart required
+            var rebootExitCodes = new List<int> { 1641, 3010 };
+
+            if(rebootExitCodes.Contains(packageResult.ExitCode))
+            {
+                if(config.Features.StopOnFirstPackageRebootRequest)
+                {
+                    throw new ApplicationException("Stopping further execution as {0} has requested a reboot.".format_with(packageResult.Name));
+                }
+            }
+
             if (!packageResult.Success)
             {
                 this.Log().Error(ChocolateyLoggers.Important, "The {0} of {1} was NOT successful.".format_with(commandName.to_string(), packageResult.Name));