Skip to content

Commit 6a2255c

Browse files
committed
HTTP99 address review feedback
Signed-off-by: davidradl <david_radley@uk.ibm.com>
1 parent ae0f475 commit 6a2255c

File tree

3 files changed

+21
-62
lines changed

3 files changed

+21
-62
lines changed

src/test/java/com/getindata/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreatorFactoryTest.java

Lines changed: 20 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,18 @@
33
*/
44
package com.getindata.connectors.http.internal.table.lookup.querycreators;
55

6+
import java.util.Collections;
67
import java.util.List;
78

89
import org.apache.flink.configuration.Configuration;
910
import org.apache.flink.table.api.DataTypes;
11+
import org.apache.flink.table.api.Schema;
1012
import org.apache.flink.table.catalog.*;
1113
import org.apache.flink.table.data.GenericRowData;
1214
import org.apache.flink.table.data.RowData;
1315
import org.apache.flink.table.data.StringData;
1416
import org.apache.flink.table.factories.DynamicTableFactory;
17+
import org.apache.flink.table.factories.FactoryUtil;
1518
import org.junit.jupiter.api.BeforeEach;
1619
import org.junit.jupiter.api.Test;
1720
import static org.assertj.core.api.Assertions.assertThat;
@@ -24,7 +27,6 @@
2427
import com.getindata.connectors.http.internal.table.lookup.RowDataSingleValueLookupSchemaEntry;
2528
import static com.getindata.connectors.http.internal.table.lookup.HttpLookupTableSourceFactory.row;
2629
import static com.getindata.connectors.http.internal.table.lookup.querycreators.GenericJsonAndUrlQueryCreatorFactory.*;
27-
import static com.getindata.connectors.http.internal.table.lookup.querycreators.QueryCreatorUtils.getTableContext;
2830

2931
class GenericJsonAndUrlQueryCreatorFactoryTest
3032
{
@@ -114,4 +116,21 @@ void optionsTests() {
114116
assertThat(factory.optionalOptions()).contains(REQUEST_BODY_FIELDS);
115117
assertThat(factory.optionalOptions()).contains(REQUEST_URL_MAP);
116118
}
119+
public static DynamicTableFactory.Context getTableContext(Configuration config,
120+
ResolvedSchema resolvedSchema) {
121+
return new FactoryUtil.DefaultDynamicTableContext(
122+
ObjectIdentifier.of("default", "default", "test"),
123+
new ResolvedCatalogTable(
124+
CatalogTable.of(
125+
Schema.newBuilder().fromResolvedSchema(resolvedSchema).build(),
126+
null,
127+
Collections.emptyList(),
128+
Collections.emptyMap()),
129+
resolvedSchema),
130+
Collections.emptyMap(),
131+
config,
132+
Thread.currentThread().getContextClassLoader(),
133+
false
134+
);
135+
}
117136
}

src/test/java/com/getindata/connectors/http/internal/table/lookup/querycreators/GenericJsonAndUrlQueryCreatorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import com.getindata.connectors.http.internal.table.lookup.RowDataSingleValueLookupSchemaEntry;
3030
import static com.getindata.connectors.http.internal.table.lookup.HttpLookupConnectorOptions.LOOKUP_METHOD;
3131
import static com.getindata.connectors.http.internal.table.lookup.HttpLookupTableSourceFactory.row;
32-
import static com.getindata.connectors.http.internal.table.lookup.querycreators.QueryCreatorUtils.getTableContext;
32+
import static com.getindata.connectors.http.internal.table.lookup.querycreators.GenericJsonAndUrlQueryCreatorFactoryTest.getTableContext;
3333

3434
class GenericJsonAndUrlQueryCreatorTest {
3535

src/test/java/com/getindata/connectors/http/internal/table/lookup/querycreators/QueryCreatorUtils.java

Lines changed: 0 additions & 60 deletions
This file was deleted.

0 commit comments

Comments
 (0)