Skip to content

Commit 9959855

Browse files
committed
review comment
1 parent fec9b6f commit 9959855

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

ggml/src/ggml-sycl/binbcast.cpp

+2-4
Original file line numberDiff line numberDiff line change
@@ -79,14 +79,12 @@ template <float (*bin_op)(const float, const float)> struct bin_bcast_sycl {
7979
const bool src1_is_contiguous, const bool dst_is_contiguous, queue_ptr stream) {
8080
auto check_bcast_required = [](const std::array<int64_t, 4> & src_dims,
8181
const std::array<int64_t, 4> & dst_dims) -> bool {
82-
bool requires_broadcast = false;
8382
for (int i = 0; i < 4; i++) {
8483
if (dst_dims[i] > src_dims[i]) {
85-
requires_broadcast = true;
86-
break;
84+
return true;
8785
}
8886
}
89-
return requires_broadcast;
87+
return false;
9088
};
9189

9290
dpct::has_capability_or_fail(stream->get_device(), { sycl::aspect::fp16 });

0 commit comments

Comments
 (0)