Merge pull request #114 from github/no-symbol-plane-without-alt

iansan5653 · web-flow · commit caec920f5fc7 · 2023-12-05T11:56:09.000-05:00
Don't use symbol plane unless `Alt` is pressed
diff --git a/src/hotkey.ts b/src/hotkey.ts
@@ -47,7 +47,8 @@ export function eventToHotkeyString(
   }
 
   if (!modifierKeyNames.includes(key)) {
-    const nonOptionPlaneKey = matchApplePlatform.test(platform) ? macosSymbolLayerKeys[key] ?? key : key
+    const nonOptionPlaneKey =
+      hotkeyString.includes('Alt') && matchApplePlatform.test(platform) ? macosSymbolLayerKeys[key] ?? key : key
     const syntheticKey = syntheticKeyNames[nonOptionPlaneKey] ?? nonOptionPlaneKey
     hotkeyString.push(syntheticKey)
   }
diff --git a/src/macos-symbol-layer.ts b/src/macos-symbol-layer.ts
@@ -16,7 +16,6 @@ export const macosSymbolLayerKeys: Record<string, string> = {
   ['º']: '0',
   ['–']: '-',
   ['≠']: '=',
-  ['`']: '`',
   ['⁄']: '!',
   ['€']: '@',
   ['‹']: '#',

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,8 @@ export function eventToHotkeyString(`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`if (!modifierKeyNames.includes(key)) {`
`50`		`- const nonOptionPlaneKey = matchApplePlatform.test(platform) ? macosSymbolLayerKeys[key] ?? key : key`
	`50`	`+ const nonOptionPlaneKey =`
	`51`	`+ hotkeyString.includes('Alt') && matchApplePlatform.test(platform) ? macosSymbolLayerKeys[key] ?? key : key`
`51`	`52`	`const syntheticKey = syntheticKeyNames[nonOptionPlaneKey] ?? nonOptionPlaneKey`
`52`	`53`	`hotkeyString.push(syntheticKey)`
`53`	`54`	`}`