[39.1.1 and newer] [Moodle 4.1] admin/filters.php settings link leads nowhere

[danowar2k]

Describe the bug
On the admin/filters.php page, if a filter has settings, a link to the filter plugin settings is generated. filter_synhi declares settings. The generated link leads to admin/settings.php?section=filtersettingsynhi .
This link leads nowhere, because there is no such section.

The section means a settings page. This here

moodle-filter_synhi/settings.php

Line 59 in d0c4eac

$page = new admin_settingpage('filter_synhi_settings', get_string('settings', 'filter_synhi'));

says the name of the settings page is "filter_synhi_settings". When you change that to "filtersettingsynhi", the link leads to the filter settings of filter_synhi. Maybe that is what you want it to be, instead of a link to the category (don't know if that works).

To Reproduce
Steps to reproduce the behaviour:

1. Go to admin/filters.php
2. Click on the "Settings" link to admin/settings.php?section=filtersettingsynhi.
3. See an error that says the section is nonexistent

Expected behaviour
The link should lead to the settings page of filter_synhi.

Versions (please complete the following information):

• Moodle: 4.1.13
• Filter: 39.1.1 (but the code is also like this in the newest version)
• Browser and version: Chrome 131.0.6778.205 on Windows 10

Additional context
Add any other context about the problem here.

[gjb2048]

https://github.com/gjbarnard/moodle-filter_synhi/blob/MOODLE_401/Readme.md?plain=1#L151-L155 -> https://moodle.org/plugins/filter_synhi/39.1.2/30100.

[danowar2k]

So you request me to replicate the issue in Moodle 4.1.15? If so, okay, I'll report back.
Or do you mean I should replicate the issue in the newest plugin version V39.1.2 ?

By "Cannot replicate" you mean you couldn't replicate the bug in the newest Moodle release and the newest plugin version?
Asking because that will indicate what I'm looking for...

[gjb2048]

By "Cannot replicate" is means that I can't replicate on Moodle 4.1.14+ (Build: 20241011), with V39.1.2 and that before raising issues that you kindly ensure that you are running "the current version for your release of Moodle" before I spend time looking at an issue that may have already been addressed.

[danowar2k]

Okay. I've checked out moodle/moodle@f1fbfdf (weekly 4.1.15+) and the plugin version https://github.com/gjbarnard/moodle-filter_synhi/releases/tag/V39.1.2

and tested again.

admin/filters.php still shows the following link:

Which leads to the error page.

[danowar2k]

This fix should do it: #14 (at least it fixes my Moodle 4.1 settings link)

[gjb2048]

@danowar2k I can now replicate, thanks for the information and patch. With the latter I have implemented a better solution that is in line with the M4.3+ version - though possibly won't work on M4.0-.

[danowar2k]

Ah you use Boost's tab function so that you can let the admin/filters.php link be a link to the whole tab group. I think I understand.

[danowar2k]

What's your preferred process in issues? Do you close them yourselves or do you want me to check out the solution and close the ticket if I agree?

[gjb2048]

@danowar2k I manage everything and will ask accordingly given the individual circumstances.