Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer I would like to see sp.nov. without not return NO_ANNOT #140

Closed
mjy opened this issue Jul 13, 2023 · 4 comments
Closed

As a developer I would like to see sp.nov. without not return NO_ANNOT #140

mjy opened this issue Jul 13, 2023 · 4 comments

Comments

@mjy
Copy link

mjy commented Jul 13, 2023

Probably an issue with token handling requiring spaces. If we can't handle here I'll pre-propcess the text.

3.2.1 :022 > t = 'Turripria woldai sp.nov'
 => "Turripria woldai sp.nov" 
3.2.1 :023 > t = 'Turripria woldai sp.nov'
 => "Turripria woldai sp.nov" 
3.2.1 :024 > r = Vendor::Gnfinder.result(t, project_id: 13)
 => 
#<Vendor::Gnfinder::Result:0x0000000117aedae0
... 
3.2.1 :025 > r.names.first.found.annotation_nomen_type
 => "NO_ANNOT" 
@dimus
Copy link
Member

dimus commented Jul 13, 2023

makes sense, I'll think how to deal with this.

@mjy
Copy link
Author

mjy commented Jul 13, 2023

Other combinations that seems to not be detecting:

  • Coccidencyrtus pomadus sp. nov..\n (could be wrong on this)

@mjy
Copy link
Author

mjy commented Jul 13, 2023

Other combinations that succeed, somewhat unexpectedly:

  • Coccidencyrtus pomadus sp. nov...
  • *#Cheiloneurus nasica sp. nov..,

@dimus
Copy link
Member

dimus commented Jul 17, 2023

Other combinations that seems to not be detecting:

  • Coccidencyrtus pomadus sp. nov..\n (could be wrong on this)

I think this is part of #143

@dimus dimus closed this as completed in e3123c9 Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants