Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Previously full "current{RecordId,NameId,Name,(Cardinality),CanonicalSimple,CanonicalFull}" fields are empty? #153

Open
Adafede opened this issue May 27, 2024 · 2 comments

Comments

@Adafede
Copy link

Adafede commented May 27, 2024

Hi @dimus!
Thank you for your constant work and improvements made to your tools.
Some of my tests did not pass lately as for some DBs, all current... fields are empty.

See the difference between 1 and 4,179,180 (main ones I noted empty):

echo "Callichroma iris" | gnfinder -A -f compact -M -s 1,4,179,180

Is this expected and I did not follow the latest updates properly?

Best,

@dimus
Copy link
Member

dimus commented Jun 11, 2024

@Adafede thank so much for spotting this. I suspect it is related to gnames/gnames#128, and I would say that for names where taxonomicStatus is accepted, there should be a consistency. Let me figure out what is going on.

There are two data sources, with classification (taxonomic) and without. For ones with classification gnverifier can see if a name is a current name or not. If there is no classification I used to give a name as a current, even I they don't give any opinion.

So if name got resolved to a data source with classification, posssible (simplified) taxonomicStatus can be 'Accepted' or 'Synonym' and current name appears.
If there is no classification, then taxonomicStatus would be 'N/A' and current name should not appear.

@dimus
Copy link
Member

dimus commented Jun 11, 2024

On a related topic, empty fields for currently accepted name should probably be hidden, when not used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants