Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grc721: Should SetTokenURI be removed from IGRC721 interface? #3500

Open
stefann-01 opened this issue Jan 13, 2025 · 0 comments
Open

grc721: Should SetTokenURI be removed from IGRC721 interface? #3500

stefann-01 opened this issue Jan 13, 2025 · 0 comments

Comments

@stefann-01
Copy link
Contributor

Description

According to ERC721 standard, TokenURI functionality belongs in the metadata extension (IERC721Metadata). However, in our implementation:

  1. SetTokenURI exists in the base IGRC721 interface
  2. TokenURI exists in IGRC721Metadata interface

This seems inconsistent with the standard. Should we:

  • Remove SetTokenURI from IGRC721
  • Move it to IGRC721Metadata
  • Or keep current implementation for a specific reason?

Reference: https://eips.ethereum.org/EIPS/eip-721#specification
@stefann-01 stefann-01 changed the title grc721: Should SetTokenURI be removed from IGRC721 interface? grc721: Should SetTokenURI be removed from **IGRC721** interface? Jan 13, 2025
@stefann-01 stefann-01 changed the title grc721: Should SetTokenURI be removed from **IGRC721** interface? grc721: Should SetTokenURI be removed from IGRC721 interface? Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
🧙‍♂️gno.land core team
Status: Triage
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stefann-01