Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: should tm2/pkg/cmap be deprecated as it predates Go's standard library sync.Map #3505

Open
odeke-em opened this issue Jan 14, 2025 · 1 comment

Comments

@odeke-em
Copy link
Contributor

For the beta and mainnet launch, per the call for audits it has been requested that tm2 also be audited but while doing so I noticed this code https://github.com/gnolang/gno/blob/master/tm2/pkg/cmap/cmap.go in which really it is just a map with a mutex but doesn't account for load characteristics and content the way that Go's standard library https://pkg.go.dev/sync#Map

Perhaps let us delete the code in cmap and instead use sync.Map

Kindly paging @n2p5 @moul @petar-dambovaliev

@thehowl
Copy link
Member

thehowl commented Jan 14, 2025

Agreed, let's change it to a sync.Map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

2 participants