Skip to content
This repository was archived by the owner on Sep 7, 2021. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.

Commit ada24d3

Browse files
committed
fix tests
1 parent 46eac9d commit ada24d3

File tree

3 files changed

+27
-23
lines changed

3 files changed

+27
-23
lines changed

session_cond_test.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ func TestBuilder(t *testing.T) {
3838

3939
colNameName := "`" + mapper.Obj2Table("ColName") + "`"
4040
opName := "`" + mapper.Obj2Table("Op") + "`"
41+
valueName := "`" + mapper.Obj2Table("Value") + "`"
4142

4243
var cond Condition
4344
has, err := testEngine.Where(builder.Eq{colNameName: "col1"}).Get(&cond)
@@ -51,7 +52,7 @@ func TestBuilder(t *testing.T) {
5152
assert.NoError(t, err)
5253
assert.Equal(t, true, has, "records should exist")
5354

54-
has, err = testEngine.Where(builder.Eq{colNameName: "col1", opName: OpEqual, "value": "1"}).
55+
has, err = testEngine.Where(builder.Eq{colNameName: "col1", opName: OpEqual, valueName: "1"}).
5556
NoAutoCondition().
5657
Get(&cond)
5758
assert.NoError(t, err)

session_exist_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ func TestExistStruct(t *testing.T) {
4646
assert.NoError(t, err)
4747
assert.False(t, has)
4848

49-
nameName := mapper.Obj2Table("Name")
49+
nameName := "`" + mapper.Obj2Table("Name") + "`"
5050

5151
has, err = testEngine.Where(nameName+" = ?", "test1").Exist(&RecordExist{})
5252
assert.NoError(t, err)

session_find_test.go

+24-21
Original file line numberDiff line numberDiff line change
@@ -151,10 +151,10 @@ func TestFind3(t *testing.T) {
151151

152152
tableName := mapper.Obj2Table("TeamUser")
153153
teamTableName := mapper.Obj2Table("Team")
154-
idName := mapper.Obj2Table("Id")
155-
orgIDName := mapper.Obj2Table("OrgId")
156-
uidName := mapper.Obj2Table("Uid")
157-
teamIDName := mapper.Obj2Table("TeamId")
154+
idName := "`" + mapper.Obj2Table("Id") + "`"
155+
orgIDName := "`" + mapper.Obj2Table("OrgId") + "`"
156+
uidName := "`" + mapper.Obj2Table("Uid") + "`"
157+
teamIDName := "`" + mapper.Obj2Table("TeamId") + "`"
158158

159159
var teams []Team
160160
err = testEngine.Cols("`"+teamTableName+"`."+idName).
@@ -181,7 +181,7 @@ func TestFind3(t *testing.T) {
181181
assert.NoError(t, err)
182182

183183
teams = make([]Team, 0)
184-
err = testEngine.Cols("`"+teamTableName+"`.id").
184+
err = testEngine.Cols("`"+teamTableName+"`."+idName).
185185
Where("`tu`."+orgIDName+"=?", 1).
186186
And("`tu`."+uidName+"=?", 2).
187187
Join("INNER", []string{tableName, "tu"}, "`tu`."+teamIDName+"=`"+teamTableName+"`."+idName).
@@ -267,7 +267,7 @@ func TestOrder(t *testing.T) {
267267
assert.NoError(t, prepareEngine())
268268
assertSync(t, new(Userinfo))
269269

270-
idName := mapper.Obj2Table("Id")
270+
idName := "id"
271271
userName := mapper.Obj2Table("Username")
272272
heightName := mapper.Obj2Table("Height")
273273

@@ -286,7 +286,7 @@ func TestGroupBy(t *testing.T) {
286286
assert.NoError(t, prepareEngine())
287287
assertSync(t, new(Userinfo))
288288

289-
idName := mapper.Obj2Table("Id")
289+
idName := "id"
290290
userName := mapper.Obj2Table("Username")
291291

292292
users := make([]Userinfo, 0)
@@ -298,7 +298,7 @@ func TestHaving(t *testing.T) {
298298
assert.NoError(t, prepareEngine())
299299
assertSync(t, new(Userinfo))
300300

301-
userName := mapper.Obj2Table("Username")
301+
userName := "`" + mapper.Obj2Table("Username") + "`"
302302

303303
users := make([]Userinfo, 0)
304304
err := testEngine.GroupBy(userName).Having(userName + "='xlw'").Find(&users)
@@ -319,7 +319,7 @@ func TestFindInts(t *testing.T) {
319319
assertSync(t, new(Userinfo))
320320

321321
userinfo := testEngine.GetTableMapper().Obj2Table("Userinfo")
322-
idName := mapper.Obj2Table("Id")
322+
idName := "id"
323323

324324
var idsInt64 []int64
325325
err := testEngine.Table(userinfo).Cols(idName).Desc(idName).Find(&idsInt64)
@@ -363,7 +363,7 @@ func TestFindStrings(t *testing.T) {
363363
assertSync(t, new(Userinfo))
364364
userinfo := testEngine.GetTableMapper().Obj2Table("Userinfo")
365365
username := testEngine.GetColumnMapper().Obj2Table("Username")
366-
idName := mapper.Obj2Table("Id")
366+
idName := "id"
367367

368368
var idsString []string
369369
err := testEngine.Table(userinfo).Cols(username).Desc(idName).Find(&idsString)
@@ -378,7 +378,7 @@ func TestFindMyString(t *testing.T) {
378378
assertSync(t, new(Userinfo))
379379
userinfo := testEngine.GetTableMapper().Obj2Table("Userinfo")
380380
username := testEngine.GetColumnMapper().Obj2Table("Username")
381-
idName := mapper.Obj2Table("Id")
381+
idName := "id"
382382

383383
var idsMyString []MyString
384384
err := testEngine.Table(userinfo).Cols(username).Desc(idName).Find(&idsMyString)
@@ -394,7 +394,7 @@ func TestFindInterface(t *testing.T) {
394394

395395
userinfo := testEngine.GetTableMapper().Obj2Table("Userinfo")
396396
username := testEngine.GetColumnMapper().Obj2Table("Username")
397-
idName := mapper.Obj2Table("Id")
397+
idName := "id"
398398

399399
var idsInterface []interface{}
400400
err := testEngine.Table(userinfo).Cols(username).Desc(idName).Find(&idsInterface)
@@ -409,7 +409,7 @@ func TestFindSliceBytes(t *testing.T) {
409409
assertSync(t, new(Userinfo))
410410

411411
userinfo := testEngine.GetTableMapper().Obj2Table("Userinfo")
412-
idName := mapper.Obj2Table("Id")
412+
idName := "id"
413413

414414
var ids [][][]byte
415415
err := testEngine.Table(userinfo).Desc(idName).Find(&ids)
@@ -426,7 +426,7 @@ func TestFindSlicePtrString(t *testing.T) {
426426
assertSync(t, new(Userinfo))
427427

428428
userinfo := testEngine.GetTableMapper().Obj2Table("Userinfo")
429-
idName := mapper.Obj2Table("Id")
429+
idName := "id"
430430

431431
var ids [][]*string
432432
err := testEngine.Table(userinfo).Desc(idName).Find(&ids)
@@ -443,7 +443,7 @@ func TestFindMapBytes(t *testing.T) {
443443
assertSync(t, new(Userinfo))
444444

445445
userinfo := testEngine.GetTableMapper().Obj2Table("Userinfo")
446-
idName := mapper.Obj2Table("Id")
446+
idName := "id"
447447

448448
var ids []map[string][]byte
449449
err := testEngine.Table(userinfo).Desc(idName).Find(&ids)
@@ -460,7 +460,7 @@ func TestFindMapPtrString(t *testing.T) {
460460
assertSync(t, new(Userinfo))
461461

462462
userinfo := testEngine.GetTableMapper().Obj2Table("Userinfo")
463-
idName := mapper.Obj2Table("Id")
463+
idName := "id"
464464

465465
var ids []map[string]*string
466466
err := testEngine.Table(userinfo).Desc(idName).Find(&ids)
@@ -497,7 +497,6 @@ func TestFindBit(t *testing.T) {
497497
}
498498

499499
func TestFindMark(t *testing.T) {
500-
501500
type Mark struct {
502501
Mark1 string `xorm:"VARCHAR(1)"`
503502
Mark2 string `xorm:"VARCHAR(1)"`
@@ -557,27 +556,31 @@ func TestFindAndCountOneFunc(t *testing.T) {
557556
assert.EqualValues(t, 2, len(results))
558557
assert.EqualValues(t, 2, cnt)
559558

559+
idName := "`" + mapper.Obj2Table("Id") + "`"
560+
msgName := "`" + mapper.Obj2Table("Msg") + "`"
561+
contentName := "`" + mapper.Obj2Table("Content") + "`"
562+
560563
results = make([]FindAndCountStruct, 0, 1)
561-
cnt, err = testEngine.Where("msg = ?", true).FindAndCount(&results)
564+
cnt, err = testEngine.Where(msgName+" = ?", true).FindAndCount(&results)
562565
assert.NoError(t, err)
563566
assert.EqualValues(t, 1, len(results))
564567
assert.EqualValues(t, 1, cnt)
565568

566569
results = make([]FindAndCountStruct, 0, 1)
567-
cnt, err = testEngine.Where("msg = ?", true).Limit(1).FindAndCount(&results)
570+
cnt, err = testEngine.Where(msgName+" = ?", true).Limit(1).FindAndCount(&results)
568571
assert.NoError(t, err)
569572
assert.EqualValues(t, 1, len(results))
570573
assert.EqualValues(t, 1, cnt)
571574

572575
results = make([]FindAndCountStruct, 0, 1)
573-
cnt, err = testEngine.Where("msg = ?", true).Select("id, content, msg").
576+
cnt, err = testEngine.Where(msgName+" = ?", true).Select(idName + ", " + contentName + ", " + msgName).
574577
Limit(1).FindAndCount(&results)
575578
assert.NoError(t, err)
576579
assert.EqualValues(t, 1, len(results))
577580
assert.EqualValues(t, 1, cnt)
578581

579582
results = make([]FindAndCountStruct, 0, 1)
580-
cnt, err = testEngine.Where("msg = ?", true).Desc("id").
583+
cnt, err = testEngine.Where(msgName+" = ?", true).Desc(idName).
581584
Limit(1).FindAndCount(&results)
582585
assert.NoError(t, err)
583586
assert.EqualValues(t, 1, len(results))

0 commit comments

Comments
 (0)