Skip to content

Commit 3807dce

Browse files
committed
Merge branch 'measurabledatatoken/master' into dev
- Fix whitespace issues all over - Re-generate all bindata - Drop the bump to the version number
2 parents 235c3c5 + 7f65680 commit 3807dce

File tree

8 files changed

+180
-122
lines changed

8 files changed

+180
-122
lines changed

CONTRIBUTING.md

+16-2
Original file line numberDiff line numberDiff line change
@@ -50,24 +50,38 @@ with the Github code review tools. Then it will be merged into dev, and later go
5050
```
5151

5252
1. Write your changes
53-
1. If you changed template files, run the following command
53+
1. If you changed template files, run the following command to re-generate the binddata.
5454

5555
```
5656
./boil.sh go-generate all
5757
```
5858

59-
1. Generate your models
59+
1. Generate executable. Run again if you have changed anything in core code or driver code.
60+
```
61+
./boil.sh build all
62+
```
63+
64+
1. Also Move sqlboiler-[driver] built to the bin of gopath if you have changed the driver code.
65+
66+
1. Generate your models from existing tables
6067

6168
```
6269
./boil.sh gen [driver]
6370
```
6471

72+
1. You may need to install following package before able to run the tests.
73+
74+
```
75+
go get -u github.com/volatiletech/null
76+
```
77+
6578
1. Test the output
6679

6780
```
6881
./boil.sh test
6982
```
7083

84+
7185
# Bugs
7286

7387
Issues should be filed on Github, simply use the template provided and fill in detail. If there's

boil.sh

+25-9
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,32 @@ build() {
1717

1818
buildPath=github.com/volatiletech/sqlboiler
1919
case "${driver}" in
20-
all) drivers="psql mysql mssql"; shift ;;
21-
psql) drivers="psql"; shift ;;
22-
mysql) drivers="mysql"; shift ;;
23-
mssql) drivers="mssql"; shift ;;
24-
*) set -o xtrace; go build "$@" "${buildPath}"; set +o xtrace; return ;;
20+
all)
21+
set -o xtrace
22+
go build "${buildPath}"
23+
{ set +o xtrace; } 2>/dev/null
24+
drivers="psql mysql mssql"
25+
shift ;;
26+
psql)
27+
drivers="psql"
28+
shift ;;
29+
mysql)
30+
drivers="mysql"
31+
shift ;;
32+
mssql)
33+
drivers="mssql"
34+
shift ;;
35+
*)
36+
set -o xtrace
37+
go build "$@" "${buildPath}"
38+
{ set +o xtrace; } 2>/dev/null
39+
return ;;
2540
esac
2641

2742
for d in $drivers; do
2843
set -o xtrace
2944
go build "$@" ${buildPath}/drivers/sqlboiler-"${d}"
45+
{ set +o xtrace; } 2>/dev/null
3046
done
3147
}
3248

@@ -65,8 +81,8 @@ test_user() {
6581
;;
6682
mysql)
6783
set -o xtrace
68-
mysql --host localhost --execute "create user ${DB_USER} identified by '${DB_PASS}';"
69-
mysql --host localhost --execute "grant all privileges on *.* to ${DB_USER};"
84+
mysql --host localhost --execute "create user ${DB_USER} identified by '${DB_PASS}';"
85+
mysql --host localhost --execute "grant all privileges on *.* to ${DB_USER};"
7086
;;
7187
mssql)
7288
set -o xtrace
@@ -150,8 +166,8 @@ driver_test_user() {
150166
;;
151167
mysql)
152168
set -o xtrace
153-
mysql --host localhost --execute "create user ${DRIVER_USER} identified by '${DB_PASS}';"
154-
mysql --host localhost --execute "grant all privileges on ${DRIVER_DB}.* to ${DRIVER_USER};"
169+
mysql --host localhost --execute "create user ${DRIVER_USER} identified by '${DB_PASS}';"
170+
mysql --host localhost --execute "grant all privileges on ${DRIVER_DB}.* to ${DRIVER_USER};"
155171
;;
156172
mssql)
157173
set -o xtrace

drivers/sqlboiler-mssql/driver/bindata.go

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

drivers/sqlboiler-mssql/driver/override/templates_test/singleton/mssql_main_test.go.tpl

+34-25
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ type mssqlTester struct {
99
sslmode string
1010
port int
1111
testDBName string
12+
skipSQLCmd bool
1213
}
1314

1415
func init() {
@@ -28,6 +29,8 @@ func (m *mssqlTester) setup() error {
2829
m.pass = viper.GetString("mssql.pass")
2930
m.port = viper.GetInt("mssql.port")
3031
m.sslmode = viper.GetString("mssql.sslmode")
32+
m.testDBName = viper.GetString("mssql.testdbname")
33+
m.skipSQLCmd = viper.GetBool("mssql.skipSQLCmd")
3134
3235
err = vala.BeginValidation().Validate(
3336
vala.StringNotEmpty(viper.GetString("mssql.user"), "mssql.user"),
@@ -42,36 +45,40 @@ func (m *mssqlTester) setup() error {
4245
}
4346

4447
// Create a randomized db name.
45-
m.testDBName = randomize.StableDBName(m.dbName)
46-
47-
if err = m.dropTestDB(); err != nil {
48-
return err
49-
}
50-
if err = m.createTestDB(); err != nil {
51-
return err
48+
if len(p.testDBName) == 0 {
49+
p.testDBName = randomize.StableDBName(p.dbName)
5250
}
5351

54-
createCmd := exec.Command("sqlcmd", "-S", m.host, "-U", m.user, "-P", m.pass, "-d", m.testDBName)
52+
if !m.skipSQLCmd {
53+
if err = m.dropTestDB(); err != nil {
54+
return err
55+
}
56+
if err = m.createTestDB(); err != nil {
57+
return err
58+
}
5559

56-
f, err := os.Open("tables_schema.sql")
57-
if err != nil {
58-
return errors.Wrap(err, "failed to open tables_schema.sql file")
59-
}
60+
createCmd := exec.Command("sqlcmd", "-S", m.host, "-U", m.user, "-P", m.pass, "-d", m.testDBName)
6061

61-
defer func() { _ = f.Close() }()
62+
f, err := os.Open("tables_schema.sql")
63+
if err != nil {
64+
return errors.Wrap(err, "failed to open tables_schema.sql file")
65+
}
6266

63-
stderr := &bytes.Buffer{}
64-
createCmd.Stdin = newFKeyDestroyer(rgxMSSQLkey, f)
65-
createCmd.Stderr = stderr
67+
defer func() { _ = f.Close() }()
6668

67-
if err = createCmd.Start(); err != nil {
68-
return errors.Wrap(err, "failed to start sqlcmd command")
69-
}
69+
stderr := &bytes.Buffer{}
70+
createCmd.Stdin = newFKeyDestroyer(rgxMSSQLkey, f)
71+
createCmd.Stderr = stderr
7072

71-
if err = createCmd.Wait(); err != nil {
72-
fmt.Println(err)
73-
fmt.Println(stderr.String())
74-
return errors.Wrap(err, "failed to wait for sqlcmd command")
73+
if err = createCmd.Start(); err != nil {
74+
return errors.Wrap(err, "failed to start sqlcmd command")
75+
}
76+
77+
if err = createCmd.Wait(); err != nil {
78+
fmt.Println(err)
79+
fmt.Println(stderr.String())
80+
return errors.Wrap(err, "failed to wait for sqlcmd command")
81+
}
7582
}
7683

7784
return nil
@@ -114,8 +121,10 @@ func (m *mssqlTester) teardown() error {
114121
m.dbConn.Close()
115122
}
116123

117-
if err := m.dropTestDB(); err != nil {
118-
return err
124+
if !m.skipSQLCmd {
125+
if err := m.dropTestDB(); err != nil {
126+
return err
127+
}
119128
}
120129

121130
return nil

0 commit comments

Comments
 (0)