Skip to content

Commit 4dfc4cf

Browse files
committed
Add some breadcrumbs to make updating json_annotation easier...later
1 parent 2d0fe3a commit 4dfc4cf

File tree

7 files changed

+19
-5
lines changed

7 files changed

+19
-5
lines changed

json_serializable/lib/src/settings.dart

+1
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ class Settings {
4545

4646
final JsonSerializable _config;
4747

48+
// #CHANGE WHEN UPDATING json_annotation
4849
ClassConfig get config => ClassConfig(
4950
checked: _config.checked ?? ClassConfig.defaults.checked,
5051
anyMap: _config.anyMap ?? ClassConfig.defaults.anyMap,

json_serializable/lib/src/type_helpers/config_types.dart

+1
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ const _$FieldRenameEnumMap = {
111111
FieldRename.pascal: 'pascal',
112112
};
113113

114+
// #CHANGE WHEN UPDATING json_annotation
114115
Map<String, dynamic> _$JsonSerializableToJson(JsonSerializable instance) =>
115116
<String, dynamic>{
116117
'any_map': instance.anyMap,

json_serializable/lib/src/utils.dart

+1
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ T enumValueForDartObject<T>(
7575

7676
/// Return an instance of [JsonSerializable] corresponding to a the provided
7777
/// [reader].
78+
// #CHANGE WHEN UPDATING json_annotation
7879
JsonSerializable _valueForAnnotation(ConstantReader reader) => JsonSerializable(
7980
anyMap: reader.read('anyMap').literalValue as bool?,
8081
checked: reader.read('checked').literalValue as bool?,

json_serializable/test/config_test.dart

+7-2
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,12 @@ void main() {
7676

7777
final configMap = Map<String, dynamic>.from(yaml);
7878

79-
expect(configMap.keys, unorderedEquals(generatorConfigDefaultJson.keys),
80-
reason: 'All supported keys are documented.');
79+
expect(
80+
configMap.keys,
81+
unorderedEquals(generatorConfigDefaultJson.keys),
82+
reason: 'All supported keys are documented. '
83+
'Did you forget to change README.md?',
84+
);
8185

8286
expect(
8387
JsonSerializable.fromJson(configMap).toJson(),
@@ -131,6 +135,7 @@ $lastLine''',
131135
});
132136
}
133137

138+
// #CHANGE WHEN UPDATING json_annotation
134139
const _invalidConfig = {
135140
'any_map': 42,
136141
'checked': 42,

json_serializable/test/custom_configuration_test.dart

+5-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,11 @@ Future<void> main() async {
110110
expected[jsonSerialKey] = generatorConfigDefaultJson[jsonSerialKey];
111111
}
112112

113-
expect(_ConfigLogger.configurations.first.toJson(), expected);
113+
expect(
114+
_ConfigLogger.configurations.first.toJson(),
115+
expected,
116+
reason: 'Did you forget to change README.md?',
117+
);
114118
},
115119
);
116120
});

json_serializable/test/shared_config.dart

+3-2
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,10 @@ import 'package:json_serializable/src/type_helpers/config_types.dart';
77

88
final jsonSerializableFields = generatorConfigDefaultJson.keys.toList();
99

10-
final generatorConfigDefaultJson = Map<String, dynamic>.unmodifiable(
11-
ClassConfig.defaults.withDefaults().toJson());
10+
final generatorConfigDefaultJson =
11+
Map<String, dynamic>.unmodifiable(ClassConfig.defaults.toJson());
1212

13+
// #CHANGE WHEN UPDATING json_annotation
1314
final generatorConfigNonDefaultJson =
1415
Map<String, dynamic>.unmodifiable(const JsonSerializable(
1516
anyMap: true,

json_serializable/test/test_sources/test_sources.dart

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ class ConfigurationImplicitDefaults {
55
int? field;
66
}
77

8+
// #CHANGE WHEN UPDATING json_annotation
89
@JsonSerializable(
910
anyMap: false,
1011
checked: false,

0 commit comments

Comments
 (0)