pw_json: Merge builder_impl.h header into builder.h

The builder_impl.h header was split out just to keep the builder.h
header from being too large. The structure was confusing and caused
issues for clang-tidy.

Change-Id: Id9bdc8d51e4d155fab70af3ecf7f17b9aa41227a
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/263333
Reviewed-by: Ted Pudlik <tpudlik@google.com>
Pigweed-Auto-Submit: Wyatt Hepler <hepler@google.com>
Commit-Queue: Wyatt Hepler <hepler@google.com>
Docs-Not-Needed: Wyatt Hepler <hepler@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>

Author: 255

pw_json/BUILD.bazel

@@ -27,11 +27,9 @@ cc_library(
     name = "builder",
     hdrs = [
         "public/pw_json/builder.h",
-        "public/pw_json/internal/builder_impl.h",
         "public/pw_json/internal/nesting.h",
     ],
     strip_include_prefix = "public",
-    tags = ["noclangtidy"],
     deps = [
         "//pw_assert",
         "//pw_status",

pw_json/BUILD.gn

@@ -30,10 +30,7 @@ pw_source_set("builder") {
     dir_pw_assert,
     dir_pw_status,
   ]
-  sources = [
-    "public/pw_json/internal/builder_impl.h",
-    "public/pw_json/internal/nesting.h",
-  ]
+  sources = [ "public/pw_json/internal/nesting.h" ]
 }
 
 pw_test("builder_test") {

pw_json/CMakeLists.txt

@@ -17,7 +17,6 @@ include($ENV{PW_ROOT}/pw_build/pigweed.cmake)
 pw_add_library(pw_json.builder INTERFACE
   HEADERS
     public/pw_json/builder.h
-    public/pw_json/internal/builder_impl.h
     public/pw_json/internal/nesting.h
   PUBLIC_INCLUDES
     public