bazel: Enable -Wconversion by default

Allowlist all targets with violations.

This change was largely autogenerated using,

  cat /tmp/targets.txt | xargs buildozer 'add features "-conversion_warnings"'

where /tmp/targets.txt contained the list of broken targets copied from
https://btx.cloud.google.com/invocations/2046c2cb-c67d-4ce6-bde1-7f6b17a64f25/targets.
But some manual fixes were required (since some targets were generated
by macros and could not be directly edited by buildozer).

NO_IFTTT=Large scale compilaton option change.

Bug: 259746255
Change-Id: I62c513434d46d945f84d388bec09e98d1b819b42
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/276754
Commit-Queue: Ted Pudlik <tpudlik@google.com>
Reviewed-by: Wyatt Hepler <hepler@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Docs-Not-Needed: Ted Pudlik <tpudlik@google.com>

Author: tpudlik

REPO.bazel

@@ -23,9 +23,7 @@ repo(
     # Pigweed, but not when compiling any dependencies hosted in external
     # repositories.
     features = [
-        # TODO: https://pwbug.dev/259746255 - Uncomment this after all broken
-        # targets are allowlisted.
-        # "conversion_warnings",
+        "conversion_warnings",
         "layering_check",
     ],
 )

pw_allocator/BUILD.bazel

@@ -119,6 +119,7 @@ cc_library(
 cc_library(
     name = "best_fit",
     hdrs = ["public/pw_allocator/best_fit.h"],
+    features = ["-conversion_warnings"],
     strip_include_prefix = "public",
     deps = [
         ":block_allocator",
@@ -132,6 +133,7 @@ cc_library(
 cc_library(
     name = "best_fit_block_allocator",
     hdrs = ["public/pw_allocator/best_fit_block_allocator.h"],
+    features = ["-conversion_warnings"],
     strip_include_prefix = "public",
     deps = [
         ":best_fit",
@@ -143,6 +145,7 @@ cc_library(
     name = "block_allocator",
     srcs = ["block_allocator.cc"],
     hdrs = ["public/pw_allocator/block_allocator.h"],
+    features = ["-conversion_warnings"],
     implementation_deps = ["//pw_assert:check"],
     strip_include_prefix = "public",
     deps = [
@@ -166,6 +169,7 @@ cc_library(
 cc_library(
     name = "bucket_allocator",
     hdrs = ["public/pw_allocator/bucket_allocator.h"],
+    features = ["-conversion_warnings"],
     strip_include_prefix = "public",
     deps = [
         ":block_allocator",
@@ -179,6 +183,7 @@ cc_library(
 cc_library(
     name = "bucket_block_allocator",
     hdrs = ["public/pw_allocator/bucket_block_allocator.h"],
+    features = ["-conversion_warnings"],
     strip_include_prefix = "public",
     deps = [":bucket_allocator"],
 )
@@ -187,6 +192,7 @@ cc_library(
     name = "buddy_allocator",
     srcs = ["buddy_allocator.cc"],
     hdrs = ["public/pw_allocator/buddy_allocator.h"],
+    features = ["-conversion_warnings"],
     implementation_deps = [
         "//pw_assert:check",
         "//pw_bytes:alignment",
@@ -256,6 +262,7 @@ alias(
 cc_library(
     name = "dl_allocator",
     hdrs = ["public/pw_allocator/dl_allocator.h"],
+    features = ["-conversion_warnings"],
     strip_include_prefix = "public",
     deps = [
         ":block_allocator",
@@ -271,6 +278,7 @@ cc_library(
 cc_library(
     name = "dual_first_fit_block_allocator",
     hdrs = ["public/pw_allocator/dual_first_fit_block_allocator.h"],
+    features = ["-conversion_warnings"],
     strip_include_prefix = "public",
     deps = [":first_fit"],
 )
@@ -291,6 +299,7 @@ cc_library(
 cc_library(
     name = "first_fit",
     hdrs = ["public/pw_allocator/first_fit.h"],
+    features = ["-conversion_warnings"],
     strip_include_prefix = "public",
     deps = [
         ":block_allocator",
@@ -304,6 +313,7 @@ cc_library(
 cc_library(
     name = "first_fit_block_allocator",
     hdrs = ["public/pw_allocator/first_fit_block_allocator.h"],
+    features = ["-conversion_warnings"],
     strip_include_prefix = "public",
     deps = [":first_fit"],
 )
@@ -312,12 +322,14 @@ cc_library(
     name = "fragmentation",
     srcs = ["fragmentation.cc"],
     hdrs = ["public/pw_allocator/fragmentation.h"],
+    features = ["-conversion_warnings"],
     strip_include_prefix = "public",
 )
 
 cc_library(
     name = "freelist_heap",
     hdrs = ["public/pw_allocator/freelist_heap.h"],
+    features = ["-conversion_warnings"],
     strip_include_prefix = "public",
     deps = [
         ":bucket_allocator",
@@ -341,6 +353,7 @@ cc_library(
 cc_library(
     name = "last_fit_block_allocator",
     hdrs = ["public/pw_allocator/last_fit_block_allocator.h"],
+    features = ["-conversion_warnings"],
     strip_include_prefix = "public",
     deps = [":first_fit"],
 )
@@ -404,6 +417,7 @@ cc_library(
 cc_library(
     name = "tlsf_allocator",
     hdrs = ["public/pw_allocator/tlsf_allocator.h"],
+    features = ["-conversion_warnings"],
     strip_include_prefix = "public",
     deps = [
         ":block_allocator",
@@ -442,6 +456,7 @@ cc_library(
 cc_library(
     name = "worst_fit",
     hdrs = ["public/pw_allocator/worst_fit.h"],
+    features = ["-conversion_warnings"],
     strip_include_prefix = "public",
     deps = [
         ":block_allocator",
@@ -455,6 +470,7 @@ cc_library(
 cc_library(
     name = "worst_fit_block_allocator",
     hdrs = ["public/pw_allocator/worst_fit_block_allocator.h"],
+    features = ["-conversion_warnings"],
     strip_include_prefix = "public",
     deps = [
         ":config",
@@ -468,6 +484,7 @@ cc_library(
     name = "testing",
     testonly = True,
     hdrs = ["public/pw_allocator/testing.h"],
+    features = ["-conversion_warnings"],
     strip_include_prefix = "public",
     deps = [
         ":buffer",
@@ -489,6 +506,7 @@ cc_library(
     testonly = True,
     srcs = ["block_allocator_testing.cc"],
     hdrs = ["public/pw_allocator/block_allocator_testing.h"],
+    features = ["-conversion_warnings"],
     implementation_deps = [
         "//pw_assert:check",
         "//pw_bytes:alignment",
@@ -514,6 +532,7 @@ cc_library(
     testonly = True,
     srcs = ["managed_ptr_testing.cc"],
     hdrs = ["public/pw_allocator/internal/managed_ptr_testing.h"],
+    features = ["-conversion_warnings"],
     strip_include_prefix = "public",
     deps = [
         ":pw_allocator",
@@ -559,6 +578,7 @@ cc_library(
 pw_cc_test(
     name = "allocator_as_pool_test",
     srcs = ["allocator_as_pool_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":allocator_as_pool",
         ":pw_allocator",
@@ -569,6 +589,7 @@ pw_cc_test(
 pw_cc_test(
     name = "allocator_test",
     srcs = ["allocator_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":pw_allocator",
         ":testing",
@@ -578,6 +599,7 @@ pw_cc_test(
 pw_cc_test(
     name = "best_fit_test",
     srcs = ["best_fit_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":best_fit",
         ":best_fit_block_allocator",
@@ -589,6 +611,7 @@ pw_cc_test(
 pw_cc_test(
     name = "bucket_allocator_test",
     srcs = ["bucket_allocator_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":block_allocator_testing",
         ":bucket_allocator",
@@ -600,6 +623,7 @@ pw_cc_test(
 pw_cc_test(
     name = "buddy_allocator_test",
     srcs = ["buddy_allocator_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":buddy_allocator",
         ":fuzzing",
@@ -610,6 +634,7 @@ pw_cc_test(
 pw_cc_test(
     name = "buffer_test",
     srcs = ["buffer_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":buffer",
         ":testing",
@@ -622,6 +647,7 @@ pw_cc_test(
 pw_cc_test(
     name = "bump_allocator_test",
     srcs = ["bump_allocator_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":bump_allocator",
         ":testing",
@@ -632,6 +658,7 @@ pw_cc_test(
 pw_cc_test(
     name = "chunk_pool_test",
     srcs = ["chunk_pool_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":chunk_pool",
         ":testing",
@@ -641,6 +668,7 @@ pw_cc_test(
 pw_cc_test(
     name = "dl_allocator_test",
     srcs = ["dl_allocator_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":block_allocator_testing",
         ":dl_allocator",
@@ -651,6 +679,7 @@ pw_cc_test(
 pw_cc_test(
     name = "fallback_allocator_test",
     srcs = ["fallback_allocator_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":fallback_allocator",
         ":testing",
@@ -661,6 +690,7 @@ pw_cc_test(
 pw_cc_test(
     name = "first_fit_test",
     srcs = ["first_fit_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":block_allocator_testing",
         ":buffer",
@@ -676,6 +706,7 @@ pw_cc_test(
 pw_cc_test(
     name = "fragmentation_test",
     srcs = ["fragmentation_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":fragmentation",
         ":testing",
@@ -685,6 +716,7 @@ pw_cc_test(
 pw_cc_test(
     name = "freelist_heap_test",
     srcs = ["freelist_heap_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":freelist_heap",
         ":testing",
@@ -697,6 +729,7 @@ pw_cc_test(
 pw_cc_test(
     name = "layout_test",
     srcs = ["layout_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":pw_allocator",
         ":testing",
@@ -708,6 +741,7 @@ pw_cc_test(
 pw_cc_test(
     name = "libc_allocator_test",
     srcs = ["libc_allocator_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":libc_allocator",
         ":testing",
@@ -723,6 +757,7 @@ pw_cc_test(
 pw_cc_test(
     name = "null_allocator_test",
     srcs = ["null_allocator_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":null_allocator",
         ":testing",
@@ -732,6 +767,7 @@ pw_cc_test(
 pw_cc_test(
     name = "pmr_allocator_test",
     srcs = ["pmr_allocator_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":pmr_allocator",
         ":testing",
@@ -741,6 +777,7 @@ pw_cc_test(
 pw_cc_test(
     name = "shared_ptr_test",
     srcs = ["shared_ptr_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":managed_ptr_testing",
         ":pw_allocator",
@@ -750,6 +787,7 @@ pw_cc_test(
 pw_cc_test(
     name = "synchronized_allocator_test",
     srcs = ["synchronized_allocator_test.cc"],
+    features = ["-conversion_warnings"],
     # TODO: b/358411629 - This test times out on rp2.
     target_compatible_with = select({
         "@pico-sdk//bazel/constraint:rp2040": ["@platforms//:incompatible"],
@@ -777,6 +815,7 @@ pw_cc_test(
 pw_cc_test(
     name = "tlsf_allocator_test",
     srcs = ["tlsf_allocator_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":block_allocator_testing",
         ":tlsf_allocator",
@@ -786,6 +825,7 @@ pw_cc_test(
 pw_cc_test(
     name = "tracking_allocator_test",
     srcs = ["tracking_allocator_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":first_fit",
         ":metrics",
@@ -800,6 +840,7 @@ pw_cc_test(
 pw_cc_test(
     name = "typed_pool_test",
     srcs = ["typed_pool_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":pw_allocator",
         ":testing",
@@ -811,6 +852,7 @@ pw_cc_test(
 pw_cc_test(
     name = "unique_ptr_test",
     srcs = ["unique_ptr_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":managed_ptr_testing",
         ":pw_allocator",
@@ -820,6 +862,7 @@ pw_cc_test(
 pw_cc_test(
     name = "weak_ptr_test",
     srcs = ["weak_ptr_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":managed_ptr_testing",
         ":pw_allocator",
@@ -829,6 +872,7 @@ pw_cc_test(
 pw_cc_test(
     name = "worst_fit_test",
     srcs = ["worst_fit_test.cc"],
+    features = ["-conversion_warnings"],
     deps = [
         ":block_allocator_testing",
         ":worst_fit",