pw_bluetooth_sapphire: Add [[maybe_unused]] where needed

Removes need for -Wno-unused-parameter which will allow us to remove
emboss's public_config disable of that warning in later CL.

Bug: 345799180
Change-Id: I7aa78d70265ed1b5d4ff28fd83989be4ee2740f8
Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/252355
Commit-Queue: David Rees <drees@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Docs-Not-Needed: David Rees <drees@google.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Josh Conner <joshconner@google.com>

Author: studgeek

pw_bluetooth_sapphire/host/l2cap/bredr_dynamic_channel_registry_fuzztest.cc

@@ -60,11 +60,11 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
       pw::bluetooth::emboss::ConnectionRole::CENTRAL,
       dispatcher);
 
-  auto open_cb = [](auto chan) {};
-  auto close_cb = [](auto chan) {};
-  auto service_chan_cb = [](auto chan) {};
+  auto open_cb = []([[maybe_unused]] auto chan) {};
+  auto close_cb = []([[maybe_unused]] auto chan) {};
+  auto service_chan_cb = []([[maybe_unused]] auto chan) {};
 
-  auto service_cb = [&](auto psm) {
+  auto service_cb = [&]([[maybe_unused]] auto psm) {
     // Reject some PSMs.
     if (provider.ConsumeBool()) {
       return std::optional<

pw_bluetooth_sapphire/host/l2cap/l2cap_fuzztest.cc

@@ -48,10 +48,11 @@ class FuzzerController : public ControllerTestDoubleBase,
 
  private:
   // Controller overrides:
-  void SendCommand(pw::span<const std::byte> command) override {}
-  void SendAclData(pw::span<const std::byte> data) override {}
-  void SendScoData(pw::span<const std::byte> data) override {}
-  void SendIsoData(pw::span<const std::byte> data) override {}
+  void SendCommand(
+      [[maybe_unused]] pw::span<const std::byte> command) override {}
+  void SendAclData([[maybe_unused]] pw::span<const std::byte> data) override {}
+  void SendScoData([[maybe_unused]] pw::span<const std::byte> data) override {}
+  void SendIsoData([[maybe_unused]] pw::span<const std::byte> data) override {}
 };
 
 // Reuse ControllerTest test fixture code even though we're not using gtest.

pw_bluetooth_sapphire/host/testing/fake_controller.cc

@@ -2612,7 +2612,8 @@ void FakeController::OnLEStartEncryptionCommand(
 }
 
 void FakeController::OnWriteSynchronousFlowControlEnableCommand(
-    const pwemb::WriteSynchronousFlowControlEnableCommandView& params) {
+    [[maybe_unused]] const pwemb::WriteSynchronousFlowControlEnableCommandView&
+        params) {
   if (!settings_.SupportedCommandsView()
            .write_synchronous_flow_control_enable()
            .Read()) {
@@ -3429,7 +3430,8 @@ void FakeController::SendAndroidLEMultipleAdvertisingStateChangeSubevent(
 }
 
 void FakeController::OnReadLocalSupportedControllerDelay(
-    const pwemb::ReadLocalSupportedControllerDelayCommandView& params) {
+    [[maybe_unused]] const pwemb::ReadLocalSupportedControllerDelayCommandView&
+        params) {
   auto packet = hci::EventPacket::New<
       pwemb::ReadLocalSupportedControllerDelayCommandCompleteEventWriter>(
       hci_spec::kCommandCompleteEventCode);

pw_bluetooth_sapphire/host/testing/fake_signaling_server.cc

@@ -188,7 +188,7 @@ void FakeSignalingServer::ProcessConfigurationRequest(
 
 void FakeSignalingServer::ProcessConfigurationResponse(
     hci_spec::ConnectionHandle conn,
-    l2cap::CommandId id,
+    [[maybe_unused]] l2cap::CommandId id,
     const ByteBuffer& configuration_res) {
   const l2cap::ChannelId local_cid =
       configuration_res
@@ -253,9 +253,10 @@ void FakeSignalingServer::SendCFrame(hci_spec::ConnectionHandle conn,
   return callback(conn, l2cap::kSignalingChannelId, response_buffer);
 }
 
-void FakeSignalingServer::SendCommandReject(hci_spec::ConnectionHandle conn,
-                                            l2cap::CommandId id,
-                                            l2cap::RejectReason reason) {
+void FakeSignalingServer::SendCommandReject(
+    hci_spec::ConnectionHandle conn,
+    l2cap::CommandId id,
+    [[maybe_unused]] l2cap::RejectReason reason) {
   DynamicByteBuffer payload_buffer(sizeof(l2cap::CommandRejectPayload));
   MutablePacketView<l2cap::CommandRejectPayload> payload_view(&payload_buffer);
   payload_view.mutable_header()->reason =

pw_bluetooth_sapphire/public/pw_bluetooth_sapphire/peripheral.h

@@ -58,7 +58,7 @@ class Peripheral final : public pw::bluetooth::low_energy::Peripheral2 {
 
     // AdvertisedPeripheral2 overrides:
     async2::Poll<pw::bluetooth::low_energy::Connection2::Ptr> PendConnection(
-        async2::Context& cx) override {
+        [[maybe_unused]] async2::Context& cx) override {
       // TODO: https://pwbug.dev/377301546 - Implement connection handling.
       return async2::Pending();
     }

pw_bluetooth_sapphire/size_report/host.cc

@@ -20,16 +20,17 @@
 namespace {
 class BloatRandomGenerator final : public pw::random::RandomGenerator {
  public:
-  void Get(pw::ByteSpan dest) override {}
+  void Get([[maybe_unused]] pw::ByteSpan dest) override {}
   void InjectEntropyBits(uint32_t /*data*/,
                          uint_fast8_t /*num_bits*/) override {}
 };
 
 class BloatDispatcher final : public pw::async::Dispatcher {
  public:
-  void PostAt(pw::async::Task& task,
-              pw::chrono::SystemClock::time_point time) override {}
-  bool Cancel(pw::async::Task& task) override { return true; }
+  void PostAt(
+      [[maybe_unused]] pw::async::Task& task,
+      [[maybe_unused]] pw::chrono::SystemClock::time_point time) override {}
+  bool Cancel([[maybe_unused]] pw::async::Task& task) override { return true; }
   pw::chrono::SystemClock::time_point now() override {
     return pw::chrono::SystemClock::time_point::min();
   }
@@ -48,7 +49,7 @@ int main() {
   bt::gap::Adapter::Config config{};
   std::unique_ptr<bt::gap::Adapter> adapter = bt::gap::Adapter::Create(
       dispatcher, transport->GetWeakPtr(), gatt->GetWeakPtr(), config);
-  auto gap_init_cb = [](bool success) {};
+  auto gap_init_cb = []([[maybe_unused]] bool success) {};
   auto transport_closed_cb = []() {};
   adapter->Initialize(std::move(gap_init_cb), std::move(transport_closed_cb));
   return 0;