Skip to content

Commit 0f6ad2e

Browse files
committed
chore: minor code imprs
1 parent c4e4902 commit 0f6ad2e

File tree

3 files changed

+31
-6
lines changed

3 files changed

+31
-6
lines changed

scripts/build-tests.mjs

+10-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,16 @@ import path from 'node:path'
1919
import * as vendor from '../build/vendor.js'
2020

2121
const root = path.resolve(new URL(import.meta.url).pathname, '../..')
22-
const apis = ['chalk', 'depseek', 'fs', 'minimist', 'ps', 'which', 'YAML']
22+
const apis = [
23+
'chalk',
24+
'depseek',
25+
'fs',
26+
'glob',
27+
'minimist',
28+
'ps',
29+
'which',
30+
'YAML',
31+
]
2332
const copyright = await fs.readFileSync(
2433
path.resolve(root, 'test/fixtures/copyright.txt'),
2534
'utf8'

src/goods.ts

+4-5
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export function updateArgv(args: string[]) {
3333
Object.assign(argv, minimist(args))
3434
}
3535

36-
export function sleep(duration: Duration): Promise<unknown> {
36+
export function sleep(duration: Duration): Promise<void> {
3737
return new Promise((resolve) => {
3838
setTimeout(resolve, parseDuration(duration))
3939
})
@@ -58,10 +58,9 @@ export function echo(pieces: TemplateStringsArray, ...args: any[]) {
5858
}
5959

6060
function stringify(arg: ProcessOutput | any) {
61-
if (arg instanceof ProcessOutput) {
62-
return arg.toString().replace(/\n$/, '')
63-
}
64-
return `${arg}`
61+
return arg instanceof ProcessOutput
62+
? arg.toString().replace(/\n$/, '')
63+
: `${arg}`
6564
}
6665

6766
export async function question(

test/vendor-export.test.js

+17
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import {
1818
chalk,
1919
depseek,
2020
fs,
21+
glob,
2122
minimist,
2223
ps,
2324
which,
@@ -198,6 +199,22 @@ describe('vendor fs API ', () => {
198199
})
199200
})
200201

202+
describe('vendor glob API ', () => {
203+
// prettier-ignore
204+
test('exports', () => {
205+
assert.equal(typeof glob, 'function')
206+
assert.equal(typeof glob.convertPathToPattern, 'function', 'glob.convertPathToPattern')
207+
assert.equal(typeof glob.globby, 'function', 'glob.globby')
208+
assert.equal(typeof glob.globbySync, 'function', 'glob.globbySync')
209+
assert.equal(typeof glob.globbyStream, 'function', 'glob.globbyStream')
210+
assert.equal(typeof glob.generateGlobTasksSync, 'function', 'glob.generateGlobTasksSync')
211+
assert.equal(typeof glob.generateGlobTasks, 'function', 'glob.generateGlobTasks')
212+
assert.equal(typeof glob.isGitIgnoredSync, 'function', 'glob.isGitIgnoredSync')
213+
assert.equal(typeof glob.isGitIgnored, 'function', 'glob.isGitIgnored')
214+
assert.equal(typeof glob.isDynamicPattern, 'function', 'glob.isDynamicPattern')
215+
})
216+
})
217+
201218
describe('vendor minimist API ', () => {
202219
// prettier-ignore
203220
test('exports', () => {

0 commit comments

Comments
 (0)