Skip to content

Commit 82a5e0b

Browse files
authored
perf(pkg): replace types deps with triple-slash refs (#1102)
1 parent 1fc9d0b commit 82a5e0b

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

.size-limit.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
{
1717
"name": "dts libdefs",
1818
"path": "build/*.d.ts",
19-
"limit": "38.5 kB",
19+
"limit": "38.7 kB",
2020
"brotli": false,
2121
"gzip": false
2222
},

package-lock.json

+2-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "zx",
3-
"version": "8.3.2",
3+
"version": "8.4.0",
44
"description": "A tool for writing better scripts",
55
"type": "module",
66
"main": "./build/index.cjs",
@@ -92,10 +92,6 @@
9292
"test:smoke:deno": "deno test ./test/smoke/deno.test.js --allow-read --allow-sys --allow-env --allow-run",
9393
"test:workflow": "zizmor .github/workflows -v -p"
9494
},
95-
"optionalDependencies": {
96-
"@types/fs-extra": ">=11",
97-
"@types/node": ">=20"
98-
},
9995
"devDependencies": {
10096
"@size-limit/file": "11.1.6",
10197
"@types/fs-extra": "11.0.4",

scripts/build-dts.mjs

+13-5
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,20 @@ for (const i in results) {
9999
await fs.writeFile(entry.outFile, result, 'utf8')
100100
}
101101

102-
// Replaces redundant triple-slash directives
102+
// Properly formats triple-slash directives
103+
const pkgEntries = ['core', 'index', 'vendor']
104+
const prefix = `/// <reference types="node" />
105+
/// <reference types="fs-extra" />
106+
107+
`
108+
103109
for (const dts of await glob(['build/**/*.d.ts', '!build/vendor-*.d.ts'])) {
104-
const contents = (await fs.readFile(dts, 'utf8'))
105-
.split('\n')
106-
.filter((line) => !line.startsWith('/// <reference types'))
107-
.join('\n')
110+
const contents =
111+
(pkgEntries.some((e) => dts.includes(e)) ? prefix : '') +
112+
(await fs.readFile(dts, 'utf8'))
113+
.split('\n')
114+
.filter((line) => !line.startsWith('/// <reference types'))
115+
.join('\n')
108116

109117
await fs.writeFile(dts, contents, 'utf8')
110118
}

0 commit comments

Comments
 (0)