From 673c2b70badaa23487efcc18a7a6326d5b9fe929 Mon Sep 17 00:00:00 2001
From: Anton Golub <antongolub@antongolub.com>
Date: Wed, 19 Feb 2025 20:05:48 +0300
Subject: [PATCH] perf(pkg): replace types deps with triple-spash refs

---
 .size-limit.json      |  2 +-
 package-lock.json     |  8 ++------
 package.json          |  6 +-----
 scripts/build-dts.mjs | 18 +++++++++++++-----
 4 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/.size-limit.json b/.size-limit.json
index bc827c0e08..2f6ce22ddd 100644
--- a/.size-limit.json
+++ b/.size-limit.json
@@ -16,7 +16,7 @@
   {
     "name": "dts libdefs",
     "path": "build/*.d.ts",
-    "limit": "38.5 kB",
+    "limit": "38.7 kB",
     "brotli": false,
     "gzip": false
   },
diff --git a/package-lock.json b/package-lock.json
index 06df4fb58a..787808118d 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "zx",
-  "version": "8.3.2",
+  "version": "8.4.0",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "zx",
-      "version": "8.3.2",
+      "version": "8.4.0",
       "license": "Apache-2.0",
       "bin": {
         "zx": "build/cli.js"
@@ -55,10 +55,6 @@
       },
       "engines": {
         "node": ">= 12.17.0"
-      },
-      "optionalDependencies": {
-        "@types/fs-extra": ">=11",
-        "@types/node": ">=20"
       }
     },
     "node_modules/@algolia/autocomplete-core": {
diff --git a/package.json b/package.json
index 826c31b7a3..ce52aaca98 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "zx",
-  "version": "8.3.2",
+  "version": "8.4.0",
   "description": "A tool for writing better scripts",
   "type": "module",
   "main": "./build/index.cjs",
@@ -92,10 +92,6 @@
     "test:smoke:deno": "deno test ./test/smoke/deno.test.js --allow-read --allow-sys --allow-env --allow-run",
     "test:workflow": "zizmor .github/workflows -v -p"
   },
-  "optionalDependencies": {
-    "@types/fs-extra": ">=11",
-    "@types/node": ">=20"
-  },
   "devDependencies": {
     "@size-limit/file": "11.1.6",
     "@types/fs-extra": "11.0.4",
diff --git a/scripts/build-dts.mjs b/scripts/build-dts.mjs
index 2dcd006a77..b60683ac9d 100644
--- a/scripts/build-dts.mjs
+++ b/scripts/build-dts.mjs
@@ -99,12 +99,20 @@ for (const i in results) {
   await fs.writeFile(entry.outFile, result, 'utf8')
 }
 
-// Replaces redundant triple-slash directives
+// Properly formats triple-slash directives
+const pkgEntries = ['core', 'index', 'vendor']
+const prefix = `/// <reference types="node" />
+/// <reference types="fs-extra" />
+
+`
+
 for (const dts of await glob(['build/**/*.d.ts', '!build/vendor-*.d.ts'])) {
-  const contents = (await fs.readFile(dts, 'utf8'))
-    .split('\n')
-    .filter((line) => !line.startsWith('/// <reference types'))
-    .join('\n')
+  const contents =
+    (pkgEntries.some((e) => dts.includes(e)) ? prefix : '') +
+    (await fs.readFile(dts, 'utf8'))
+      .split('\n')
+      .filter((line) => !line.startsWith('/// <reference types'))
+      .join('\n')
 
   await fs.writeFile(dts, contents, 'utf8')
 }