Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We don't seem to notice Faustina-Italic.glyphs is italic #1157

Closed
rsheeter opened this issue Dec 1, 2024 · 1 comment
Closed

We don't seem to notice Faustina-Italic.glyphs is italic #1157

rsheeter opened this issue Dec 1, 2024 · 1 comment
Assignees
Labels
bug Something isn't working crater Issues based on a crater diff
Milestone

Comments

@rsheeter
Copy link
Contributor

rsheeter commented Dec 1, 2024

$ python resources/scripts/ttx_diff.py 'https://github.com/Omnibus-Type/Faustina#sources/Faustina-Italic.glyphs' --compare gftools --config ~/.fontc_crater_cache/Omnibus-Type/Faustina/sources/config.yaml

# OS/2 fsSelection doesn't think we're italic
# head macStyle doesn't think we're italic
# name 2 is Regular not Italic, causing name 1 to be Faustina Light Italic instead of Faustina Light
# STAT elided fallback name is Regular rather than Italic

I see glyphsLib code that seems to take italic'ness from italicAngle, perhaps we are missing that? - e.g. https://github.com/googlefonts/glyphsLib/blob/74c63244fdbef1da540d646b0784ae6d2c3ca834/Lib/glyphsLib/builder/names.py#L25

@rsheeter rsheeter added this to the fontc 1.0 milestone Dec 1, 2024
@rsheeter rsheeter self-assigned this Dec 1, 2024
@cmyr cmyr added the crater Issues based on a crater diff label Dec 2, 2024
@rsheeter rsheeter added the bug Something isn't working label Dec 3, 2024
@rsheeter
Copy link
Contributor Author

rsheeter commented Dec 3, 2024

Fixed by #1158

@rsheeter rsheeter closed this as completed Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crater Issues based on a crater diff
Projects
None yet
Development

No branches or pull requests

2 participants