Skip to content

Commit f6bd1cd

Browse files
Karmzakkak
authored andcommitted
Fixes duration unit for days from 'f' to 'd'
see: ``` java -XX:+FlightRecorder -XX:+FlightRecorder -XX:StartFlightRecording=maxsize=10000,maxage=10000m,delay=5f,filename=flight-native.jfr -Xlog:jfr Main java.lang.IllegalArgumentException: Integer parsing error nanotime value: illegal unit whereas java -XX:+FlightRecorder -XX:+FlightRecorder -XX:StartFlightRecording=maxsize=10000,maxage=10000m,delay=5d,filename=flight-native.jfr -Xlog:jfr Main [0.562s][info][jfr] Flight Recorder initialized [0.562s][info][jfr] Created repository /tmp/2021_08_03_01_16_07_454665 [0.567s][info][jfr] Scheduled recording "1" (1) to start at 2021-08-08T01:16:07.684825 ``` Signed-off-by: Michal Karm Babacek <karm@redhat.com>
1 parent 1d4aa97 commit f6bd1cd

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

substratevm/src/com.oracle.svm.jfr/src/com/oracle/svm/jfr/JfrManager.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ private static Long parseDuration(Map<JfrStartArgument, String> args, JfrStartAr
193193
return Duration.ofMinutes(time).toNanos();
194194
} else if ("h".equals(unit)) {
195195
return Duration.ofHours(time).toNanos();
196-
} else if ("f".equals(unit)) {
196+
} else if ("d".equals(unit)) {
197197
return Duration.ofDays(time).toNanos();
198198
}
199199
throw new IllegalArgumentException("Unit is invalid.");
@@ -233,6 +233,7 @@ private static Long parseMaxSize(Map<JfrStartArgument, String> args, JfrStartArg
233233
case 'G':
234234
return number * 1024 * 1024 * 1024;
235235
default:
236+
// Unknown unit, number is treated as plain bytes
236237
return number;
237238
}
238239
} catch (IllegalArgumentException e) {

0 commit comments

Comments
 (0)