Skip to content

TODOS #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
14 tasks
chris-ramon opened this issue Mar 24, 2025 · 0 comments
Open
14 tasks

TODOS #31

chris-ramon opened this issue Mar 24, 2025 · 0 comments
Assignees

Comments

@chris-ramon
Copy link
Member

chris-ramon commented Mar 24, 2025

TODOs

  • Adds parsing the specification doc https://github.com/graphql/graphql-spec/releases/tag/October2021 to complement the graphql-js types.
    • Also as a temporal solution let's replace the default header from https://github.com/graphql/graphql-spec/releases/tag/October2021 to point the graphql-js repository.
  • Replace top path from graphql-go/... to github.com/graphql-go/....
  • Upgrade graphql-go/graphql PR: {types,graphql_test}: Adds Result.ErrorsJoined implementation. graphql#717, so the following code is replaced starting in line: https://github.com/graphql-go/compatibility-standard-definitions/blob/main/executor/go.go#L67-L81.
  • Replace types/* interface{} use with another strategy such as generics or later initialization.
  • Replace types/* self invoking fields with a working strategy.
  • Add bubbletea/bubbletea code comments.
  • Update bubbletea/bubbletea dependency, Eg. cmd.New in main.go file.
  • Add cmd/cli code comments.
  • Add types/* code comments.
  • Enable golangci-lint comments.
  • Add Unit tests.
  • Add Test coverage badges.
  • .golangci-lint disable the rule SA9004 because go assumes the type when listing a variables inside a code block using const:
  staticcheck:
    SA9004: false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant