Skip to content

Refactor pemfile.Options as the intermediate struct is not needed #8222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtcooke94 opened this issue Apr 3, 2025 · 3 comments
Closed

Refactor pemfile.Options as the intermediate struct is not needed #8222

gtcooke94 opened this issue Apr 3, 2025 · 3 comments
Assignees
Labels
Area: Auth Includes regular credentials API and implementation. Also includes advancedtls, authz, rbac etc. P2

Comments

@gtcooke94
Copy link
Contributor

The only reason for using the intermediate struct is to be able to specify a default value for the refresh interval, this could be done with the encoding/json package as follows: https://stackoverflow.com/questions/30445479/how-to-specify-default-values-when-parsing-json-in-go

See https://github.com/grpc/grpc-go/pull/8180/files#r2002089915

@arjan-bal arjan-bal added P2 Area: Auth Includes regular credentials API and implementation. Also includes advancedtls, authz, rbac etc. labels Apr 9, 2025
@hugehoo
Copy link
Contributor

hugehoo commented May 18, 2025

Hi, do you mind if i work on this issue?

@injae-kim
Copy link

Fix PR by @hugehoo : #8334

@arjan-bal
Copy link
Contributor

During the review we decided that the fixes didn't offer a significant improvement over the existing implementation, so we're not making any changes.
#8334 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Auth Includes regular credentials API and implementation. Also includes advancedtls, authz, rbac etc. P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants