Skip to content

vet/revive: resume version bump #8337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
purnesh42H opened this issue May 19, 2025 · 1 comment
Open

vet/revive: resume version bump #8337

purnesh42H opened this issue May 19, 2025 · 1 comment
Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. Status: Blocked Type: Testing

Comments

@purnesh42H
Copy link
Contributor

During our last minor release #8331, we encountered a version incompatibility with tableWriter module in the latest version of revive mgechev/revive#1345 at that time. They fixed it by replacing the tableWriter with fmt.Sprintf() mgechev/revive#1351.

For our release we skipped upgrading the revive that time because otherwise we had to wait for their patch release.

We should resume the version bump for revive once the patch is in.
@arjan-bal
Copy link
Contributor

We need to wait for revive version > v1.9.0 to be released: https://github.com/mgechev/revive/releases

@arjan-bal arjan-bal added Type: Testing Type: Dependencies Updating/adding/removing dependencies Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. Status: Blocked and removed Type: Dependencies Updating/adding/removing dependencies labels May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. Status: Blocked Type: Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@purnesh42H @arjan-bal