Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/protocols - Section 9.1: Mock Objects (2023-10-02) - Rename fixit into fakeit #249

Open
sback opened this issue Oct 17, 2023 · 0 comments
Open

/protocols - Section 9.1: Mock Objects (2023-10-02) - Rename fixit into fakeit #249

sback opened this issue Oct 17, 2023 · 0 comments
Labels
in-content Lesson content to-change Change something
Milestone
revisions

Comments

@sback
Copy link
Contributor

sback commented Oct 17, 2023 •
edited
Loading

I am not sure the semantic meaning of the name fixit matches the semantic meaning of the function itself. Since the goal of the fixit function is to replace an existing function with a Fake, I'd find the name fakeit more appropriate to represent its actual goal.

If this change is done, the corresponding tests should also be renamed. For example, test_with_fixed_return_value should likely be renamed as test_with_fake_return_value.
@gvwilson gvwilson self-assigned this Oct 17, 2023
@gvwilson gvwilson added to-change Change something in-content Lesson content labels Oct 17, 2023
@gvwilson gvwilson added this to the publication milestone Oct 17, 2023
@gvwilson gvwilson modified the milestones: publication, revisions Dec 28, 2023
@gvwilson gvwilson removed their assignment Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in-content Lesson content to-change Change something
Projects
None yet
Milestone
revisions
Development

No branches or pull requests
2 participants
@sback @gvwilson