Skip to content

Investigate and validate build_result code paths #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bushidocodes opened this issue Nov 2, 2021 · 0 comments
Open

Investigate and validate build_result code paths #63

bushidocodes opened this issue Nov 2, 2021 · 0 comments

Comments

@bushidocodes
Copy link
Contributor

A recent bug turned out to be due to calls to build_result being executed with the builder being in the right place. A fix for this was to explicitly call b.position_at_end(self.bb); at the top of the function. This task is to investigate the different code paths where build_result is called to determine if there are either:

  1. related logical bugs that the wasm test suite is not picking up
  2. a cleaner refactor that doesn't require repositioning the builder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant