Refactor ElementHandle (#2850)

* Refactor ElementHandle

* roll docs to .net 9

* it's net 8

* Assign before using

Author: kblok

.github/workflows/on-push-do-docs.yml

@@ -9,7 +9,7 @@ jobs:
     - name: Setup .NET
       uses: actions/setup-dotnet@v3
       with:
-        dotnet-version: 7.0.x
+        dotnet-version: 8.0.x
     - name: Run MarkdownSnippets
       run: |
         dotnet tool install --global MarkdownSnippets.Tool

lib/PuppeteerSharp/Cdp/CdpElementHandle.cs

@@ -37,13 +37,18 @@ public class CdpElementHandle : ElementHandle
 
     internal CdpElementHandle(
         IsolatedWorld world,
-        RemoteObject remoteObject) : base(world, remoteObject)
+        RemoteObject remoteObject)
     {
         Handle = new CdpJSHandle(world, remoteObject);
         Logger = Realm.Environment.Client.Connection.LoggerFactory.CreateLogger(GetType());
         _cdpFrame = Realm.Frame as CdpFrame;
     }
 
+    /// <inheritdoc />
+    public override RemoteObject RemoteObject => Handle.RemoteObject;
+
+    internal override IsolatedWorld Realm => Handle.Realm;
+
     /// <summary>
     /// Logger.
     /// </summary>

lib/PuppeteerSharp/Cdp/CdpJSHandle.cs

@@ -31,11 +31,18 @@ namespace PuppeteerSharp.Cdp;
 /// <inheritdoc/>
 public class CdpJSHandle : JSHandle
 {
-    internal CdpJSHandle(IsolatedWorld world, RemoteObject remoteObject) : base(world, remoteObject)
+    internal CdpJSHandle(IsolatedWorld world, RemoteObject remoteObject)
     {
+        Realm = world;
+        RemoteObject = remoteObject;
         Logger = Client.Connection.LoggerFactory.CreateLogger(GetType());
     }
 
+    /// <inheritdoc/>
+    public override RemoteObject RemoteObject { get; }
+
+    internal override IsolatedWorld Realm { get; }
+
     /// <summary>
     /// Logger.
     /// </summary>

lib/PuppeteerSharp/ElementHandle.cs

@@ -19,9 +19,7 @@ public abstract class ElementHandle : JSHandle, IElementHandle
     {
         private ElementHandle _isolatedHandle;
 
-        internal ElementHandle(
-            IsolatedWorld world,
-            RemoteObject remoteObject) : base(world, remoteObject)
+        internal ElementHandle()
         {
         }
 

lib/PuppeteerSharp/JSHandle.cs

@@ -9,21 +9,19 @@ namespace PuppeteerSharp
     /// <inheritdoc/>
     public abstract class JSHandle : IJSHandle
     {
-        internal JSHandle(IsolatedWorld world, RemoteObject remoteObject)
+        internal JSHandle()
         {
-            Realm = world;
-            RemoteObject = remoteObject;
         }
 
         /// <inheritdoc/>
         public bool Disposed { get; protected set; }
 
         /// <inheritdoc/>
-        public RemoteObject RemoteObject { get; }
+        public abstract RemoteObject RemoteObject { get; }
 
         internal Func<Task> DisposeAction { get; set; }
 
-        internal IsolatedWorld Realm { get; }
+        internal abstract IsolatedWorld Realm { get; }
 
         internal Frame Frame => Realm.Environment as Frame;